New issue
Advanced search Search tips

Issue 866947 link

Starred by 3 users
Status: Fixed
Owner:
mukai@chromium.org
Closed: Sep 21
Cc:
mustash-bugs@google.com
sadrul@chromium.org
sky@chromium.org
mukai@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 847992



Sign in to add a comment

ws needs to notify when window moves to a new display

Project Member Reported by sky@chromium.org, Jul 24 
WindowTreeHostMus caches the id of the display. This needs to be updated when the underlying window is moved to a new display. We likely need something like:

OnWindowDisplayChanged(Id window_id, int64 display_id);

This needs to be sent for all roots of a client (top-levels and embed roots). To save IPC overhead we could batch this up:

OnWindowDisplaysChanged(map<int64, Id> display_to_windows);

Comment 1 by sky@chromium.org, Jul 24

Owner: msw@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by sky@chromium.org, Aug 13

Cc: sadrul@chromium.org sky@chromium.org
 Issue 614887  has been merged into this issue.

Comment 3 by sky@chromium.org, Sep 19

Cc: mukai@chromium.org mustash-bugs@google.com
 Issue 885312  has been merged into this issue.

Comment 4 by sky@chromium.org, Sep 19

Owner: mukai@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0deeaa65c7f378fedce5a1414c448eac1022eceb

commit 0deeaa65c7f378fedce5a1414c448eac1022eceb
Author: Jun Mukai <mukai@chromium.org>
Date: Fri Sep 21 00:13:20 2018

Propagate updates of dipslay to WindowTreeHostMus

So far the display ID was recognizesed on creation of a toplevel,
but moving across displays isn't considered well.

This CL recognizes the timing of a window moving to another
display, and let WindowTreeHostMus updates its own display ID
properly.

BUG= 866947 
TEST=the new test case covers

Change-Id: I1e859f879a919674e90875a74434bb73e94edd73
Reviewed-on: https://chromium-review.googlesource.com/1234857
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593013}
[modify] https://crrev.com/0deeaa65c7f378fedce5a1414c448eac1022eceb/ash/ws/window_service_delegate_impl_unittest.cc
[modify] https://crrev.com/0deeaa65c7f378fedce5a1414c448eac1022eceb/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/0deeaa65c7f378fedce5a1414c448eac1022eceb/content/renderer/mus/renderer_window_tree_client.h
[modify] https://crrev.com/0deeaa65c7f378fedce5a1414c448eac1022eceb/services/ws/client_root.cc
[modify] https://crrev.com/0deeaa65c7f378fedce5a1414c448eac1022eceb/services/ws/public/mojom/window_tree.mojom
[modify] https://crrev.com/0deeaa65c7f378fedce5a1414c448eac1022eceb/services/ws/test_change_tracker.cc
[modify] https://crrev.com/0deeaa65c7f378fedce5a1414c448eac1022eceb/services/ws/test_change_tracker.h
[modify] https://crrev.com/0deeaa65c7f378fedce5a1414c448eac1022eceb/services/ws/test_window_tree_client.cc
[modify] https://crrev.com/0deeaa65c7f378fedce5a1414c448eac1022eceb/services/ws/test_window_tree_client.h
[modify] https://crrev.com/0deeaa65c7f378fedce5a1414c448eac1022eceb/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/0deeaa65c7f378fedce5a1414c448eac1022eceb/ui/aura/mus/window_tree_client.h

Comment 6 by mukai@chromium.org, Sep 21

Status: Fixed (was: Started)
►

Sign in to add a comment