New issue
Advanced search Search tips

Issue 866946 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

InputRouterImplTest.GestureTypesIgnoringAck is very flaky on Fuchsia x64

Project Member Reported by imch...@chromium.org, Jul 24

Issue description

This seems to have started around https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/14471.

[ RUN      ] InputRouterImplTest.GestureTypesIgnoringAck
../../content/browser/renderer_host/input/input_router_impl_unittest.cc:818: Failure
Expected equality of these values:
  0
  client_->in_flight_event_count()
    Which is: 1
Stack trace:
bt#00: pc 0x577a69102a36 (app:/pkg/bin/app,0x332da36)
bt#01: pc 0x577a691023db (app:/pkg/bin/app,0x332d3db)
bt#02: pc 0x577a681b4bcc (app:/pkg/bin/app,0x23dfbcc)
bt#03: end
../../content/browser/renderer_host/input/input_router_impl_unittest.cc:819: Failure
Value of: HasPendingEvents()
  Actual: true
Expected: false
Stack trace:
bt#00: pc 0x577a69102a36 (app:/pkg/bin/app,0x332da36)
bt#01: pc 0x577a691023db (app:/pkg/bin/app,0x332d3db)
bt#02: pc 0x577a681b4cd1 (app:/pkg/bin/app,0x23dfcd1)
bt#03: end
../../content/browser/renderer_host/input/input_router_impl_unittest.cc:814: Failure
Expected equality of these values:
  2U
    Which is: 2
  disposition_handler_->GetAndResetAckCount()
    Which is: 1
Stack trace:
bt#00: pc 0x577a69102a36 (app:/pkg/bin/app,0x332da36)
bt#01: pc 0x577a691023db (app:/pkg/bin/app,0x332d3db)
bt#02: pc 0x577a681b4ab9 (app:/pkg/bin/app,0x23dfab9)
bt#03: end
[  FAILED  ] InputRouterImplTest.GestureTypesIgnoringAck (10 ms)

https://chromium.googlesource.com/chromium/src/+/49d91137f863ad41e769ac4eb8f3ce5296c98fd9 is a likely culprit landed around the same time. sahel@ can you PTAL? I am going to disable the flaky test on Fuchsia for now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f0914725f8c05c14e2ce07d54d45597ca858405

commit 1f0914725f8c05c14e2ce07d54d45597ca858405
Author: Derek Cheng <imcheng@chromium.org>
Date: Tue Jul 24 17:29:55 2018

[Sheriff] Disable InputRouterImplTest.GestureTypesIgnoringAck on Fuchsia

It's been flaking heavily since
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/14471.

TBR=sahel@chromium.org

Bug: 866946
Change-Id: Iadbf5f330b9775d10dc5969d36f3fef8ad19a205
Reviewed-on: https://chromium-review.googlesource.com/1148597
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577596}
[modify] https://crrev.com/1f0914725f8c05c14e2ce07d54d45597ca858405/content/browser/renderer_host/input/input_router_impl_unittest.cc

Labels: -Sheriff-Chromium

Sign in to add a comment