New issue
Advanced search Search tips

Issue 866942 link

Starred by 1 user
Status: Fixed
Owner:
xiy...@chromium.org
Closed: Aug 22
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 847992



Sign in to add a comment

Get content_unittests running with --EnableFeatures=SingleProcessMash

Project Member Reported by sky@chromium.org, Jul 24 
There is special case code in content for mus. We need to run content_unittests (and content_browsertests) with --mash to ensure we are getting coverage.

We had something like this working for a while (with --mus), but it was nuked when we got rid of --mus. I think the right thing to do is similar to what we do with views_mus_unittests. That is, have content_unittests launch test_ws in a separate process. See views_mus_test_suite for how it does this.

Once we get this working we'll want to run it on the bots, similar to how we run mash_browser_tests.

Comment 1 by sky@chromium.org, Jul 24

Blocking: 847992

Comment 2 by xiy...@chromium.org, Jul 31

Blockedon: 869584
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/476e1865fc5535bc6446f54041b2a964cac12604

commit 476e1865fc5535bc6446f54041b2a964cac12604
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Wed Aug 01 16:46:26 2018

Run mash_content_unittests on bots

- Add mash_content_unittests that runs content_unittests under mash;
- Make FakeRenderWidgetHostViewAura only install delegate frame host
  when it is supported (i.e. RWHVAura has a valid |frame_sink_id_|);
- Early out a few of tests that do not work in mash;

And content_unittests still uses TestWindowTreeClientSetup since the
tests are happy with it and do not need test_ws.

Bug:  866942 
Change-Id: I664470f0efba1f350a2ae22cb978e0f3f9b2d1f5
Reviewed-on: https://chromium-review.googlesource.com/1153768
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579836}
[modify] https://crrev.com/476e1865fc5535bc6446f54041b2a964cac12604/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/476e1865fc5535bc6446f54041b2a964cac12604/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/476e1865fc5535bc6446f54041b2a964cac12604/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/476e1865fc5535bc6446f54041b2a964cac12604/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/476e1865fc5535bc6446f54041b2a964cac12604/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/476e1865fc5535bc6446f54041b2a964cac12604/testing/buildbot/test_suites.pyl
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd3f364c3e66831a2c2b224e4bfed26d89edbe5c

commit bd3f364c3e66831a2c2b224e4bfed26d89edbe5c
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Tue Aug 07 21:49:03 2018

Add a catalog to content_browsertests

The catalog includes test_ws as standalone service so that
ServiceManager could launch it with --enable-features=Mash and
--enable-service-binary-launcher;

Bug:  866942 
Change-Id: I898aa4644b0bf4307c667afdf4959d9f9c829d2b
Reviewed-on: https://chromium-review.googlesource.com/1164079
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581351}
[modify] https://crrev.com/bd3f364c3e66831a2c2b224e4bfed26d89edbe5c/content/test/BUILD.gn
[modify] https://crrev.com/bd3f364c3e66831a2c2b224e4bfed26d89edbe5c/content/test/content_test_launcher.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d38fcb5c241daecd9ee091136183ff050e21fba

commit 7d38fcb5c241daecd9ee091136183ff050e21fba
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Thu Aug 09 23:04:36 2018

chromeos: Make test_ws bring up more services

This is needed to make content_browsertests happy under mash.

Bug:  866942 
Change-Id: I21885e4328706f83bb57805abe4cff581551120a
Reviewed-on: https://chromium-review.googlesource.com/1168143
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581947}
[modify] https://crrev.com/7d38fcb5c241daecd9ee091136183ff050e21fba/services/ui/test_ws/BUILD.gn
[modify] https://crrev.com/7d38fcb5c241daecd9ee091136183ff050e21fba/services/ui/test_ws/test_gpu_interface_provider.cc
[modify] https://crrev.com/7d38fcb5c241daecd9ee091136183ff050e21fba/services/ui/test_ws/test_gpu_interface_provider.h
[modify] https://crrev.com/7d38fcb5c241daecd9ee091136183ff050e21fba/services/ui/test_ws/test_ws.cc

Comment 6 by lhchavez@chromium.org, Aug 10

Components: Internals>Services>Ash
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26258c6b0c7825458e8d440dd1a462e986fa6052

commit 26258c6b0c7825458e8d440dd1a462e986fa6052
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Mon Aug 13 17:36:59 2018

WmTestHelper uses WindowTreeFactory to create host

- WmTestHelper uses WindowTreeFactory to create its WindowTreeHostMus.
  This way, the host root window is a client created top level window
  that could receive events and could be properly resized from the
  client side;
- Update WindowTreeClientTest to use WindowTreeFactory instead of
  WindowTreeHostFactory;
- Remove no longer used WindowTreeHost/Factory mojo interfaces;

Bug:  866942 
Change-Id: I39938727142a67fc4004e4ff52656bc1f714fb57
Reviewed-on: https://chromium-review.googlesource.com/1170187
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582630}
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/services/ui/manifest.json
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/services/ui/public/interfaces/BUILD.gn
[delete] https://crrev.com/da7df9503d2aaa9f4c5a2cc6219f9bafffdfe6a2/services/ui/public/interfaces/window_tree_host.mojom
[delete] https://crrev.com/da7df9503d2aaa9f4c5a2cc6219f9bafffdfe6a2/services/ui/public/interfaces/window_tree_host_factory.mojom
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/services/ui/test_ws/test_ws.cc
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/services/ui/ws2/test_manifest.json
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/services/ui/ws2/test_window_tree_client.cc
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/services/ui/ws2/test_window_tree_client.h
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/services/ui/ws2/window_tree_client_unittest.cc
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/ui/wm/BUILD.gn
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/ui/wm/test/wm_test_helper.cc
[modify] https://crrev.com/26258c6b0c7825458e8d440dd1a462e986fa6052/ui/wm/test/wm_test_helper.h

Comment 8 by sky@chromium.org, Aug 14

Summary: Get content_unittests running with --EnableFeatures=SingleProcessMash (was: Get content_unittests running with --mash)
Xiyuan, I'm going to change this based on introducing single-process-mash. This should now use single-process-mash.

Comment 10 by xiy...@chromium.org, Aug 21

Blockedon: -869584

Comment 11 by xiy...@chromium.org, Aug 22

Status: Fixed (was: Assigned)
single_process_mash_content_unittests runs on chromeos bots.

content_browsertests work will be tracked in 874089.
►

Sign in to add a comment