New issue
Advanced search Search tips

Issue 866937 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 26
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

enable_proguard_obfuscation = false stopped working

Project Member Reported by mvanouwe...@chromium.org, Jul 24

Issue description

Setting enable_proguard_obfuscation = false in args.gn seems to have stopped working. I get the following error when I run "gn gen out/foo":

ERROR at //chrome/android/BUILD.gn:1507:11: Assignment had no effect.
          [ "//base/android/proguard/disable_chromium_obfuscation.flags" ]
          ^--------------------------------------------------------------
You set the variable "proguard_config_exclusions" here and it was unused before it went
out of scope.
See //chrome/android/BUILD.gn:1491:3: whence it was called.
  instrumentation_test_apk("monochrome_public_test_ar_apk") {
  ^----------------------------------------------------------
See //BUILD.gn:329:9: which caused the file to be included.
        "//chrome/android:chrome_junit_tests",
        ^------------------------------------

I thought this might be related to the recent upgrade to pylint 1.5.x but adding #pylint: disable=W0612 doesn't help.

Just deleting the variable assignment does seem to work.

Assigning to bsheedy as he recently added the relevant line in BUILD.gn in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1101958
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac4d1414cdd08db293d410ade86e97e1d9de21ac

commit ac4d1414cdd08db293d410ade86e97e1d9de21ac
Author: Michael van Ouwerkerk <mvanouwerkerk@google.com>
Date: Wed Jul 25 09:12:53 2018

Delete unused proguard_config_exclusions variable.

Bug:  866937 
Change-Id: Ifc6e7824491f6b89de24d97800852d2288cc9d28
Reviewed-on: https://chromium-review.googlesource.com/1148565
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577825}
[modify] https://crrev.com/ac4d1414cdd08db293d410ade86e97e1d9de21ac/chrome/android/BUILD.gn

Status: Fixed (was: Assigned)
Looks like nothing else uses the proguard_config_exclusions variable anymore, so I think it's safe to leave this removed.

Sign in to add a comment