[WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/1148235 |
|||
Issue descriptionWPT import https://crrev.com/c/1148235 introduced new failures in external/wpt/svg: List of new failures: external/wpt/svg/render/reftests/blending-002.svg [ Failure ] external/wpt/svg/render/reftests/blending-001.svg [ Failure ] This import contains upstream changes from 4273df6e126baad0a456c321b3dae1d754cfe687 to 86543323c57653f13529c74297c11547820c3563: Reduce the output when fetching the git history in ci: https://github.com/web-platform-tests/wpt/commit/86543323c57653f13529c74297c11547820c3563 Update wptrunner for new config: https://github.com/web-platform-tests/wpt/commit/3b02e29929bb0062d2c7b5a4ccfaae242bbc4c75 Update make_hosts_file for new config: https://github.com/web-platform-tests/wpt/commit/590cb1745653d1b55d9be5c761fa950f999428d0 Don't pass the sslconfig through server startup: https://github.com/web-platform-tests/wpt/commit/a6e33105a8335e101ec8c5f1cd6d76775e3a64f9 Convert the config to a builder pattern.: https://github.com/web-platform-tests/wpt/commit/020e53ba4c7c35bbcfa80699d160b76c482880f2 Fix sort order of hostnames when generating certificates.: https://github.com/web-platform-tests/wpt/commit/2957a8316b2a8f473de7f7c2e5e7243e8e74b81a Merge pull request #12008 from Tavmjong/blending: https://github.com/web-platform-tests/wpt/commit/20b68a5bb65b7566aa9d40f8e80d0d5e682a5fd0 Update mozinstall from 1.15 to 1.16.0 (#11627): https://github.com/web-platform-tests/wpt/commit/b305e43f8a9d2a94931d673d90606c1d01d1231f Add basic blending tests.: https://github.com/web-platform-tests/wpt/commit/a1b6bc5ed14b1242b8bc7842b857a2b0f0480444 [affecting this directory]
,
Aug 15
Heh, so this test has a few stroked rects to avoid (anti)aliasing issues - and we fail because of (anti)aliasing differences on the rects added to avoid said issues =P. I'd suspect that the underlying issue is that a layer used for the blending (of the strokes on the mentioned rects) is too tightly, thus clipping out the anti-aliasing on the affected edges (top and left.) Given that the actual test is passing though, and this isn't really testing accuracy of things like those mentioned in the last paragraph, I'll see if I can tweak the test to avoid that issue altogether. FTR, it appears that for instance Firefox renders correctly (as far as visually discernible that is), but still fails according to wpt.fyi, so tweaking the test doesn't feel like a horrible thing to do.
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f9e8f5d8bcf5b4dc62a5bff8a14e50e96e097d7 commit 5f9e8f5d8bcf5b4dc62a5bff8a14e50e96e097d7 Author: Fredrik Söderquist <fs@opera.com> Date: Wed Aug 15 16:33:06 2018 Tweak cover blending in wpt/svg/render/reftests/blending-00[12].svg Set 'mix-blend-mode' to 'normal' on the stroked rects that make up the "edge cover". Hopefully this avoids aliasing artifacts on the edge cover itself. In blending-002.svg, localize the use of (non-auto) isolation to the content of the test. BUG= 866928 Change-Id: I269e01a4d814f7fd8e202ffdf71c1a1d5dc48347 Reviewed-on: https://chromium-review.googlesource.com/1175825 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#583277} [modify] https://crrev.com/5f9e8f5d8bcf5b4dc62a5bff8a14e50e96e097d7/third_party/WebKit/LayoutTests/external/wpt/svg/render/reftests/blending-001.svg [modify] https://crrev.com/5f9e8f5d8bcf5b4dc62a5bff8a14e50e96e097d7/third_party/WebKit/LayoutTests/external/wpt/svg/render/reftests/blending-002.svg
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13267ec562001da0197b1df5bc9595ee60372140 commit 13267ec562001da0197b1df5bc9595ee60372140 Author: Fredrik Söderquist <fs@opera.com> Date: Thu Aug 16 09:06:38 2018 external/wpt/svg/render/reftests/blending-00[12].svg now pass TBR=schenney@chromium.org BUG= 866928 Change-Id: I3d228b5596e2c644399882f0c5c697ff0d882b6e Reviewed-on: https://chromium-review.googlesource.com/1177383 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#583586} [modify] https://crrev.com/13267ec562001da0197b1df5bc9595ee60372140/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 16
|
|||
►
Sign in to add a comment |
|||
Comment 1 by schenney@chromium.org
, Jul 30Status: Available (was: Untriaged)