New issue
Advanced search Search tips

Issue 866922 link

Starred by 1 user
Status: Fixed
Owner:
mahmadi@chromium.org
Closed: Jul 26
Cc:
justincohen@chromium.org
rogerm@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

AutofillSettingsTestCase should not rely on saving an address via form submission

Project Member Reported by mahmadi@chromium.org, Jul 24 
Currently AutofillSettingsTestCase relies on saving an address via form submission in order to populate the settings page. Profiles should instead be directly added to the PersonalDataManager to prevent the tests from breaking for reasons unrelated to the settings page itself.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f470c72014c3bf3d0af8ff6bf6fc4ba7b32e7f4b

commit f470c72014c3bf3d0af8ff6bf6fc4ba7b32e7f4b
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Jul 26 14:45:47 2018

[AF][IOS] Add profiles directly to PDM in Autofill settings EG tests

Bug:  866922 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I37c634cc378214a10861b0a1fc3f8b3f8b97a2a3
Reviewed-on: https://chromium-review.googlesource.com/1149119
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578300}
[modify] https://crrev.com/f470c72014c3bf3d0af8ff6bf6fc4ba7b32e7f4b/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm

Comment 2 by mahmadi@chromium.org, Jul 26

Status: Fixed (was: Started)
►

Sign in to add a comment