New issue
Advanced search Search tips

Issue 866913 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Some device do not have serial numbers in the vpd

Project Member Reported by haddowk@chromium.org, Jul 24

Issue description


As the next gen moblab has two nic and so 2 mac addresses the unique id for the device was moved to the serial number

it turns out that in the field some devices do not have serial number set in the vpd, and default to NoSerialNumber,

If no serial number fall back on the mac address listed in the vpd.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d2798fe07a9fb64a9d2c052969a82b24057273ac

commit d2798fe07a9fb64a9d2c052969a82b24057273ac
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Jul 25 07:14:58 2018

[moblab] Fix the unique id generation to fallback to mac address.

For next gen moblab we moved to using the serial number in the
vpd, however it seems some guado moblabs in the field do not have
a serial number so for now fall back to the mac address in the vpd.

TEST=ad hoc testing on moblab
BUG= chromium:866913 

Change-Id: I3efa4d12e0fbce0bb257174d805a433f811f549b
Reviewed-on: https://chromium-review.googlesource.com/1148642
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/d2798fe07a9fb64a9d2c052969a82b24057273ac/client/common_lib/utils.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-release-R68-10718.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a7de37332f0a6140ab24c67b503ac2e1bd8ead1c

commit a7de37332f0a6140ab24c67b503ac2e1bd8ead1c
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Jul 25 14:54:52 2018

[moblab] Fix the unique id generation to fallback to mac address.

For next gen moblab we moved to using the serial number in the
vpd, however it seems some guado moblabs in the field do not have
a serial number so for now fall back to the mac address in the vpd.

TEST=ad hoc testing on moblab
BUG= chromium:866913 

Change-Id: I3efa4d12e0fbce0bb257174d805a433f811f549b
Reviewed-on: https://chromium-review.googlesource.com/1148642
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
(cherry picked from commit d2798fe07a9fb64a9d2c052969a82b24057273ac)
Reviewed-on: https://chromium-review.googlesource.com/1149998
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/a7de37332f0a6140ab24c67b503ac2e1bd8ead1c/client/common_lib/utils.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-release-R67-10575.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cd88ac7d88563d36893ec64e7fe3b4336b3196e4

commit cd88ac7d88563d36893ec64e7fe3b4336b3196e4
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Jul 25 14:54:53 2018

[moblab] Fix the unique id generation to fallback to mac address.

For next gen moblab we moved to using the serial number in the
vpd, however it seems some guado moblabs in the field do not have
a serial number so for now fall back to the mac address in the vpd.

TEST=ad hoc testing on moblab
BUG= chromium:866913 

Change-Id: I3efa4d12e0fbce0bb257174d805a433f811f549b
Reviewed-on: https://chromium-review.googlesource.com/1148642
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
(cherry picked from commit d2798fe07a9fb64a9d2c052969a82b24057273ac)
Reviewed-on: https://chromium-review.googlesource.com/1149997
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/cd88ac7d88563d36893ec64e7fe3b4336b3196e4/client/common_lib/utils.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/eb0c3e9023a8d8ae6197900b1cf95186d39506ec

commit eb0c3e9023a8d8ae6197900b1cf95186d39506ec
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Jul 25 14:54:54 2018

[moblab] Fix the unique id generation to fallback to mac address.

For next gen moblab we moved to using the serial number in the
vpd, however it seems some guado moblabs in the field do not have
a serial number so for now fall back to the mac address in the vpd.

TEST=ad hoc testing on moblab
BUG= chromium:866913 

Change-Id: I3efa4d12e0fbce0bb257174d805a433f811f549b
Reviewed-on: https://chromium-review.googlesource.com/1148642
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
(cherry picked from commit d2798fe07a9fb64a9d2c052969a82b24057273ac)
Reviewed-on: https://chromium-review.googlesource.com/1149999
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/eb0c3e9023a8d8ae6197900b1cf95186d39506ec/client/common_lib/utils.py

Status: Fixed (was: Assigned)

Sign in to add a comment