Flaky crash in SystemDisplayApiTest.SetDisplay on Win10 Tests x64 (dbg) |
|||
Issue descriptionPossibly due to https://chromium-review.googlesource.com/c/chromium/src/+/1139048 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2060 [ RUN ] SystemDisplayApiTest.SetDisplay DevTools listening on ws://127.0.0.1:52644/devtools/browser/d3d3fb9d-c07b-4eee-b161-8cc0e0a1175c Received fatal exception EXCEPTION_ACCESS_VIOLATION Backtrace: extensions::ExtensionWebRequestEventRouter::ExtensionWebRequestEventRouter [0x00007FF7F9BC2729+249] extensions::ExtensionWebRequestEventRouter::GetInstance [0x00007FF7F9BBF81F+95] scoped_refptr<extensions::WebRequestRulesRegistry>::scoped_refptr<extensions::WebRequestRulesRegistry> [0x00007FF7F98BF046+118] base::internal::FunctorTraits<void (__cdecl*)(content::BrowserContext * __ptr64,int,scoped_refptr<extensions::WebRequestRulesRegistry>),void>::Invoke<void (__cdecl*const & __ptr64)(content::BrowserContext * __ptr64,int,scoped_refptr<extensions::WebRequest [0x00007FF7F98C6E82+130] base::internal::InvokeHelper<0,void>::MakeItSo<void (__cdecl*const & __ptr64)(content::BrowserContext * __ptr64,int,scoped_refptr<extensions::WebRequestRulesRegistry>),content::BrowserContext * __ptr64 const & __ptr64,int const & __ptr64,scoped_refptr<ext [0x00007FF7F98C6D56+102] base::internal::Invoker<base::internal::BindState<void (__cdecl*)(content::BrowserContext * __ptr64,int,scoped_refptr<extensions::WebRequestRulesRegistry>),content::BrowserContext * __ptr64,int,scoped_refptr<extensions::WebRequestRulesRegistry> >,void __c [0x00007FF7F98C6CE1+145] base::internal::Invoker<base::internal::BindState<void (__cdecl*)(content::BrowserContext * __ptr64,int,scoped_refptr<extensions::WebRequestRulesRegistry>),content::BrowserContext * __ptr64,int,scoped_refptr<extensions::WebRequestRulesRegistry> >,void __c [0x00007FF7F98C6B5C+60] base::OnceCallback<void __cdecl(void)>::Run [0x00007FFC44CEC321+97] base::debug::TaskAnnotator::RunTask [0x00007FFC44D53DA3+915] base::MessageLoop::RunTask [0x00007FFC44DF78C7+951] base::MessageLoop::DeferOrRunPendingTask [0x00007FFC44DF8113+83] base::MessageLoop::DoWork [0x00007FFC44DF85AA+746] base::MessagePumpForIO::DoRunLoop [0x00007FFC44E06A45+37] base::MessagePumpWin::Run [0x00007FFC44E04DBC+140] base::MessageLoop::Run [0x00007FFC44DF714C+524] base::RunLoop::Run [0x00007FFC44ED38DA+506] base::Thread::Run [0x00007FFC44FF766E+366] content::BrowserProcessSubThread::IOThreadRun [0x00007FFC27752918+56] content::BrowserProcessSubThread::Run [0x00007FFC27752802+306] base::Thread::ThreadMain [0x00007FFC44FF7ECD+1293] base::PlatformThread::GetCurrentThreadPriority [0x00007FFC44FE9FA3+1027] BaseThreadInitThunk [0x00007FFC65902774+20] RtlUserThreadStart [0x00007FFC66000D51+33]
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf2c7f57a69dc8b80cb107ff613717a007a19ecd commit bf2c7f57a69dc8b80cb107ff613717a007a19ecd Author: Clark DuVall <cduvall@chromium.org> Date: Mon Aug 27 23:16:21 2018 Re-enable SystemDisplayApiTest.SetDisplay Ran this a few hundred times with Win dbg setup, and couldn't reproduce the failure. Will monitor Win10 Tests x64 (dbg) bot after this goes in. Bug: 866904 Change-Id: I6ec6940e1f14e9a6260fb5064acd9d741548b91c Reviewed-on: https://chromium-review.googlesource.com/1188774 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586475} [modify] https://crrev.com/bf2c7f57a69dc8b80cb107ff613717a007a19ecd/extensions/browser/api/system_display/system_display_apitest.cc
,
Aug 28
Failed on https://ci.chromium.org/buildbot/chromium.clang/CrWinAsanCov/1170 immediately after re-enabling. Maybe try building with is_asan=true locally?
,
Aug 28
On https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan%28dll%29/1136 too. On https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/1160 on the main waterfall too (only in one build out of the last 5 there).
,
Aug 28
Thanks! I was able to repro with asan, CL up for a fix at http://crrev.com/c/1194579.
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d96e2e6a29225250675d799905d8c22312a74565 commit d96e2e6a29225250675d799905d8c22312a74565 Author: Clark DuVall <cduvall@chromium.org> Date: Wed Aug 29 22:42:20 2018 Fix flakiness in SystemDisplayApiTest.SetDisplay RulesRegistryService posts tasks to the IO thread which access ExtensionWebRequestEventRouter::GetInstance(). ExtensionWebRequestEventRouter accesses ExtensionsAPIClient::Get(), which used to be destroyed before the tasks could run in some situations. This change moves destruction of ExtensionsAPIClient to ShellBrowserMainParts::PostDestroyThreads(), which should be safe since tasks will no longer run at that time. Bug: 866904 Change-Id: I974d474d08ff9d7c0c727a7c95d26f04363ce7f0 Reviewed-on: https://chromium-review.googlesource.com/1194579 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#587343} [modify] https://crrev.com/d96e2e6a29225250675d799905d8c22312a74565/extensions/shell/browser/shell_browser_main_parts.cc
,
Aug 29
,
Aug 29
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 24