New issue
Advanced search Search tips

Issue 866897 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MIlo 500 on /swarming/task/:id/steps/*logname

Project Member Reported by qyears...@chromium.org, Jul 24

Issue description

Examples from 2018-07-23:

GET /swarming/task/3ec83a07ce5d4b10/steps/Run_test/0/stdout 500
In log: original error: googleapi: Error 404: 3ec83a07ce5d4b10 not found.

GET /swarming/task/3ee27c699424e910/steps/Install_OTA/0/stdout 500
In log: original error: googleapi: Error 404: 3ee27c699424e910 not found.

Certainly, these tasks appear not to exist:
https://chromium-swarm.appspot.com/task?id=3ee27c699424e910
https://chromium-swarm.appspot.com/task?id=3ec83a07ce5d4b10
...

Why would someone be requesting logs for a task that doesn't exist? It's probably linked somewhere. Also, this should perhaps be 404.
 
I'm able to reproduce these by visiting:
https://ci.chromium.org/swarming/task/3ec83a07ce5d4b10/steps/Run_test/0/stdout
etc.

And also by typing in a bogus but valid looking task/log:
https://ci.chromium.org/swarming/task/3ec83a07ce5d4b11/steps/foo/stdout

And also I get a 500 if I type an invalid task ID:
https://ci.chromium.org/swarming/task/123/steps/foo/stdout
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/4ca69b1fa981b7a376ff1b1b02682d649a7a6f56

commit 4ca69b1fa981b7a376ff1b1b02682d649a7a6f56
Author: Ryan Tseng <hinoka@google.com>
Date: Tue Jul 24 20:47:35 2018

[milo] Deal with Swarming 404s appropriately

Bug: 866897
Change-Id: I782a61aec83afaf9e7a1cd8224fc8bc849f0fd9b
Reviewed-on: https://chromium-review.googlesource.com/1148762
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/4ca69b1fa981b7a376ff1b1b02682d649a7a6f56/milo/buildsource/swarming/build.go

Sign in to add a comment