Add option to run without field trials |
|||||
Issue descriptionContext: We want to be able to run benchmarks on older Chrome versions. This is currently not possible, however, because Telemetry today generates a large command line file which is not accepted by earlier versions of Chrome (today there is a cap of 64 KiB [1], in the past this used to be as low as 8 KiB). The large file size is mostly due to Telemetry having to include the fieldtrial testing config, which is pretty large this days. To work around this issue we propose the creation of a new flag: --no-fieldtrial-config, which would cause Telemetry to skip adding of such fieldtrial configs, currently done at [3]. This is expected to be a flag only used by users explicitly requesting it. No behavior change is intended on perf bots or the default experience for developers (which should still use the fieldtrial configs). Ned: Hope this sounds OK to you? [1]: https://chromium.googlesource.com/chromium/src/+/6ca636534ee4f00452f91ac0dd99b7067c253fb7/base/android/java/src/org/chromium/base/CommandLine.java#159 [2]: https://codereview.chromium.org/2675713004 [3]: https://cs.chromium.org/chromium/src/tools/perf/core/perf_benchmark.py?rcl=54339ac9c0eda7fce6b9b2ec96714760e619fdc9&l=112
,
Jul 24
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/eabb49e63f3d0481d187bc1b19064cee23108ce8 commit eabb49e63f3d0481d187bc1b19064cee23108ce8 Author: Leonard Ge <wangge@google.com> Date: Mon Jul 30 14:36:22 2018 Add new flag '--compatibility-mode' to Run Benchmark in Compatibility Mode This flag is added and will be used in CL:1150032 and later CLs. So that we could run benchmarks in early versions of Chrome. The reason for adding this benchmark is that earlier versions of Chrome (versions before M60) have a configuration file size limit, so we need to remove the field trials command using this flag to reduce file size, also, '--ignore-certificate-errors-spki-list' flag is not supported in earlier versions of the browsers, so we need to use '--ignore-certificate-errors' instead. There might be some other configuration change that is required in future, which can be made using this flag. Bug: chromium:866881 Change-Id: I8d26fd8bd667b97faa0701c8063b5a4b641d590c Reviewed-on: https://chromium-review.googlesource.com/1150026 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Leonard Ge <wangge@google.com> [modify] https://crrev.com/eabb49e63f3d0481d187bc1b19064cee23108ce8/telemetry/telemetry/internal/browser/browser_options.py
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d90752f4de56af3f18685a73d7b9ce23458f698 commit 8d90752f4de56af3f18685a73d7b9ce23458f698 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon Jul 30 18:59:53 2018 Roll src/third_party/catapult dd9e5b9c8c10..0f2c4fec1272 (2 commits) https://chromium.googlesource.com/catapult.git/+log/dd9e5b9c8c10..0f2c4fec1272 git log dd9e5b9c8c10..0f2c4fec1272 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 dtu@chromium.org [pinpoint] Rename "Values" to "Get results". 2018-07-30 wangge@google.com Add new flag '--compatibility-mode' to Run Benchmark in Compatibility Mode Created with: gclient setdep -r src/third_party/catapult@0f2c4fec1272 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:866881 TBR=sullivan@chromium.org Change-Id: I9c8ba6acf9bc368320880b603b4453953a0f033d Reviewed-on: https://chromium-review.googlesource.com/1155227 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579106} [modify] https://crrev.com/8d90752f4de56af3f18685a73d7b9ce23458f698/DEPS
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/8786c7f1de1c6bbe134e22940e73e743d0f97f87 commit 8786c7f1de1c6bbe134e22940e73e743d0f97f87 Author: Leonard Ge <wangge@google.com> Date: Tue Jul 31 09:12:02 2018 Add attribute `compatibility_mode` to `BrowserOptions` Class. This CL tries to fix the test error in CL:1150032. This change should be made in CL:1150026, however I thought it would not be necessary since if you call the `UpdateFromParseResults` function in `browser_option.py`, the field `compatibility_mode` will be set. While in the unit test, this is not the case. So I added the field `compatibility_mode` to `BrowserOptions` class' `__init__` method, so that it will be initialized right after the creation of BrowserOptions instance. And the code in CL:1150032 can access this field in the test cases. Bug: chromium:866881 Change-Id: I692ce881abd4074827c1d8959de116a4632ce504 Reviewed-on: https://chromium-review.googlesource.com/1155126 Commit-Queue: Leonard Ge <wangge@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/8786c7f1de1c6bbe134e22940e73e743d0f97f87/telemetry/telemetry/internal/browser/browser_options.py
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33517519aa0cc1c81d7dbe9353daba92514717f6 commit 33517519aa0cc1c81d7dbe9353daba92514717f6 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Jul 31 10:31:21 2018 Roll src/third_party/catapult 65f883bb7739..8786c7f1de1c (1 commits) https://chromium.googlesource.com/catapult.git/+log/65f883bb7739..8786c7f1de1c git log 65f883bb7739..8786c7f1de1c --date=short --no-merges --format='%ad %ae %s' 2018-07-31 wangge@google.com Add attribute `compatibility_mode` to `BrowserOptions` Class. Created with: gclient setdep -r src/third_party/catapult@8786c7f1de1c The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:866881 TBR=sullivan@chromium.org Change-Id: Ia68a25335236898b764a3af2905032d8a2716f11 Reviewed-on: https://chromium-review.googlesource.com/1156249 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579364} [modify] https://crrev.com/33517519aa0cc1c81d7dbe9353daba92514717f6/DEPS
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9acbbf92a642c56869e46ed2ef3f40439c8ba49 commit c9acbbf92a642c56869e46ed2ef3f40439c8ba49 Author: Leonard Ge <wangge@google.com> Date: Tue Jul 31 13:43:04 2018 Avoiding Add Field Trials Configuration If in Compatibility Mode In this CL, we use the flag that is added in CL:1150026 to test whether telemetry is in compatibility mode, if so, we will not add the field trials configuration to bypass earlier Chromes' configuration file size limit in order to run benchmark on them. Corresponding test case is added as well. Some style change is also included to keep gpylint happy. Bug: chromium:866881 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I97bd81ce14b45afb5995f0c3d925aa3ef4d0810b Reviewed-on: https://chromium-review.googlesource.com/1150032 Commit-Queue: Leonard Ge <wangge@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#579390} [modify] https://crrev.com/c9acbbf92a642c56869e46ed2ef3f40439c8ba49/tools/perf/core/perf_benchmark.py [modify] https://crrev.com/c9acbbf92a642c56869e46ed2ef3f40439c8ba49/tools/perf/core/perf_benchmark_unittest.py
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/100f0ee2ceb7b787e4743d9ec8154210bc047bc4 commit 100f0ee2ceb7b787e4743d9ec8154210bc047bc4 Author: Leonard Ge <wangge@google.com> Date: Tue Jul 31 14:23:57 2018 Use `--ignore-certificate-error` if in Compatibility Mode In this CL, we ask the Telemetry to use the `ignore-certificate-error` flag i- nstead of the `--ignore-certificate-errors-spki-list`, since the older Chrome doesn't support the `--ignore-certificate-errors-spki-list` flag. The CL also includes some minor style change to keep gpylint happy. Bug: chromium:866881 Change-Id: I6107eb311aff2833bc0540f719c2749d0044f77f Reviewed-on: https://chromium-review.googlesource.com/1155117 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Leonard Ge <wangge@google.com> [modify] https://crrev.com/100f0ee2ceb7b787e4743d9ec8154210bc047bc4/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2998a12c645c8217787c0b7a1963024cb10cefe3 commit 2998a12c645c8217787c0b7a1963024cb10cefe3 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Jul 31 17:30:04 2018 Roll src/third_party/catapult cf56f6f1be08..100f0ee2ceb7 (2 commits) https://chromium.googlesource.com/catapult.git/+log/cf56f6f1be08..100f0ee2ceb7 git log cf56f6f1be08..100f0ee2ceb7 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 wangge@google.com Use `--ignore-certificate-error` if in Compatibility Mode 2018-07-31 sadrul@chromium.org tabs: Report tab-switching request delay. Created with: gclient setdep -r src/third_party/catapult@100f0ee2ceb7 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:866881 ,chromium:858944 TBR=sullivan@chromium.org Change-Id: Icfdb76c18f63fc0451154b71e6df45b6a19a85cb Reviewed-on: https://chromium-review.googlesource.com/1156488 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579455} [modify] https://crrev.com/2998a12c645c8217787c0b7a1963024cb10cefe3/DEPS
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/59a61beec4fe224d586001e265d0dc53f6bae618 commit 59a61beec4fe224d586001e265d0dc53f6bae618 Author: Leonard Ge <wangge@google.com> Date: Wed Aug 01 14:21:54 2018 Use Legacy Command Line Path in Compatibility Mode. In this CL, we let the `FlagChanger` class to used the `_CMDLINE_DIR_LEGACY` flag instead of the `_CMDLINE_DIR` if it's in compatibility mode. The reason is that for milestone before 54, Chrome will try to find the command line config file from the legacy path. The default is to use `_CMDLINE_DIR`. Correspondingly, we let the caller of the `FlagChanger` in `android_browser_finder.py` to pass in the compatibility_mode flag. There is also some minor style change in this CL. Bug: chromium:866881 Change-Id: I5f45293cf83365636bd6aa080d7acb90a3f99833 Reviewed-on: https://chromium-review.googlesource.com/1156684 Commit-Queue: Leonard Ge <wangge@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/59a61beec4fe224d586001e265d0dc53f6bae618/devil/devil/android/flag_changer_test.py [modify] https://crrev.com/59a61beec4fe224d586001e265d0dc53f6bae618/devil/devil/android/flag_changer.py [modify] https://crrev.com/59a61beec4fe224d586001e265d0dc53f6bae618/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8751706f01eb0b6e4cc65ea09d26ddc85547fe45 commit 8751706f01eb0b6e4cc65ea09d26ddc85547fe45 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Aug 01 17:10:32 2018 Roll src/third_party/catapult 226b95461af2..59a61beec4fe (2 commits) https://chromium.googlesource.com/catapult.git/+log/226b95461af2..59a61beec4fe git log 226b95461af2..59a61beec4fe --date=short --no-merges --format='%ad %ae %s' 2018-08-01 wangge@google.com Use Legacy Command Line Path in Compatibility Mode. 2018-08-01 wangge@google.com Skip Downloading the APK If it exists Created with: gclient setdep -r src/third_party/catapult@59a61beec4fe The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:866881 , chromium:863390 TBR=sullivan@chromium.org Change-Id: Iecf499e6080a0b86e168089b4f41f0c99c4be5b3 Reviewed-on: https://chromium-review.googlesource.com/1158725 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579843} [modify] https://crrev.com/8751706f01eb0b6e4cc65ea09d26ddc85547fe45/DEPS
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/27928c385ec671307c0734012fafe1edf23aefdc commit 27928c385ec671307c0734012fafe1edf23aefdc Author: Leonard Ge <wangge@google.com> Date: Fri Aug 03 17:35:11 2018 Add Failback for `chrome.gpuBenchmarking.pageScaleFactor` In this CL, a function to get the `chrome.gpuBenchmarking.pageScaleFactor` is added to ensure that it could fail back gracefully if the `pageScaleFactor` is not present. This is required if we are going to run benchmark on M49 and before. Bug: chromium:866881 Change-Id: Ia71c8e6b744a297df5bd57f126786f93aa623523 Reviewed-on: https://chromium-review.googlesource.com/1161930 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Leonard Ge <wangge@google.com> [modify] https://crrev.com/27928c385ec671307c0734012fafe1edf23aefdc/telemetry/telemetry/internal/actions/scroll.js [modify] https://crrev.com/27928c385ec671307c0734012fafe1edf23aefdc/telemetry/telemetry/internal/actions/drag.js [modify] https://crrev.com/27928c385ec671307c0734012fafe1edf23aefdc/telemetry/telemetry/internal/actions/swipe.js [modify] https://crrev.com/27928c385ec671307c0734012fafe1edf23aefdc/telemetry/telemetry/internal/actions/gesture_common.js
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92543e82547f1e85b8dac55853be6ce791ea8518 commit 92543e82547f1e85b8dac55853be6ce791ea8518 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Aug 03 18:39:34 2018 Roll src/third_party/catapult f6027ed1df0b..27928c385ec6 (1 commits) https://chromium.googlesource.com/catapult.git/+log/f6027ed1df0b..27928c385ec6 git log f6027ed1df0b..27928c385ec6 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 wangge@google.com Add Failback for `chrome.gpuBenchmarking.pageScaleFactor` Created with: gclient setdep -r src/third_party/catapult@27928c385ec6 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:866881 TBR=sullivan@chromium.org Change-Id: Id597e4f161e9c44b79c86132ee408695fd4c6d7c Reviewed-on: https://chromium-review.googlesource.com/1162382 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580611} [modify] https://crrev.com/92543e82547f1e85b8dac55853be6ce791ea8518/DEPS
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/717723b904a53e4d0b672772cb64291b50baad6b commit 717723b904a53e4d0b672772cb64291b50baad6b Author: Leonard Ge <wangge@google.com> Date: Wed Aug 15 10:03:51 2018 Redo Telemetry Compatibility Mode. In this CL, we change the `--compatibility-mode` flag from a binary switch to store a list of compatibility change that we want to enforce. We might add some new chocies in later stage. Minor style change has also been made in this CL. Bug: chromium:866881 Change-Id: I96e749c201398bf17924b4407d325a2094a327c4 Reviewed-on: https://chromium-review.googlesource.com/1174721 Commit-Queue: Leonard Ge <wangge@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/717723b904a53e4d0b672772cb64291b50baad6b/telemetry/telemetry/internal/browser/browser_options.py [add] https://crrev.com/717723b904a53e4d0b672772cb64291b50baad6b/telemetry/telemetry/compact_mode_options.py [modify] https://crrev.com/717723b904a53e4d0b672772cb64291b50baad6b/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/5c9b9cb65208b856672e0f88d6f1a1c44ef6bb31 commit 5c9b9cb65208b856672e0f88d6f1a1c44ef6bb31 Author: Ned Nguyen <nednguyen@google.com> Date: Wed Aug 15 22:04:52 2018 Revert "Redo Telemetry Compatibility Mode." This reverts commit 717723b904a53e4d0b672772cb64291b50baad6b. Reason for revert: breaking gpu Telemetry tests See logs in https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_optional_gpu_tests_rel/6576 Original change's description: > Redo Telemetry Compatibility Mode. > > In this CL, we change the `--compatibility-mode` flag from a binary switch to > store a list of compatibility change that we want to enforce. We might add some > new chocies in later stage. > > Minor style change has also been made in this CL. > > Bug: chromium:866881 > Change-Id: I96e749c201398bf17924b4407d325a2094a327c4 > Reviewed-on: https://chromium-review.googlesource.com/1174721 > Commit-Queue: Leonard Ge <wangge@google.com> > Reviewed-by: Ned Nguyen <nednguyen@google.com> TBR=perezju@chromium.org,nednguyen@google.com,wangge@google.com Change-Id: Id60447b93d923a282d962c28d0f53f7ae0c93a9f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:866881 Reviewed-on: https://chromium-review.googlesource.com/1175762 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/5c9b9cb65208b856672e0f88d6f1a1c44ef6bb31/telemetry/telemetry/internal/browser/browser_options.py [delete] https://crrev.com/a9e5877d09a0d2d2f324ee973ca9fb6fe95f5449/telemetry/telemetry/compact_mode_options.py [modify] https://crrev.com/5c9b9cb65208b856672e0f88d6f1a1c44ef6bb31/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e8db5715c511e47074f6804d201e81f8a402758 commit 6e8db5715c511e47074f6804d201e81f8a402758 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Aug 16 00:41:21 2018 Roll src/third_party/catapult fc13545ed4c9..5c9b9cb65208 (6 commits) https://chromium.googlesource.com/catapult.git/+log/fc13545ed4c9..5c9b9cb65208 git log fc13545ed4c9..5c9b9cb65208 --date=short --no-merges --format='%ad %ae %s' 2018-08-15 nednguyen@google.com Revert "Redo Telemetry Compatibility Mode." 2018-08-15 simonhatch@chromium.org Remove cq_name 2018-08-15 simonhatch@chromium.org Enable LUCI windows tryserver. 2018-08-15 benjhayden@chromium.org Fix descriptors for huge test suites. 2018-08-15 amyqiu@google.com Make small fixes to metrics visualization tool 2018-08-15 wangge@google.com Redo Telemetry Compatibility Mode. Created with: gclient setdep -r src/third_party/catapult@5c9b9cb65208 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:866881 , chromium:825433 , chromium:866881 TBR=sullivan@chromium.org Change-Id: Ia3f3e9f449f318460d4f3afb528a40b079f69417 Reviewed-on: https://chromium-review.googlesource.com/1176245 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583469} [modify] https://crrev.com/6e8db5715c511e47074f6804d201e81f8a402758/DEPS
,
Aug 16
This is due to an import error: `ImportError: cannot import name compact_mode_options`
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/5314945fa47aafd1edb930ace2590bdc7c874632 commit 5314945fa47aafd1edb930ace2590bdc7c874632 Author: Leonard Ge <wangge@google.com> Date: Thu Aug 16 09:02:49 2018 Reland "Redo Telemetry Compatibility Mode." This is a reland of 717723b904a53e4d0b672772cb64291b50baad6b Original change's description: > Redo Telemetry Compatibility Mode. > > In this CL, we change the `--compatibility-mode` flag from a binary switch to > store a list of compatibility change that we want to enforce. We might add some > new chocies in later stage. > > Minor style change has also been made in this CL. > > Bug: chromium:866881 > Change-Id: I96e749c201398bf17924b4407d325a2094a327c4 > Reviewed-on: https://chromium-review.googlesource.com/1174721 > Commit-Queue: Leonard Ge <wangge@google.com> > Reviewed-by: Ned Nguyen <nednguyen@google.com> Bug: chromium:866881 Change-Id: I6494d9fe962fe80522ad2ddf34aee67dcf56830b NOTRY=true # dashboard flake Change-Id: I6494d9fe962fe80522ad2ddf34aee67dcf56830b Reviewed-on: https://chromium-review.googlesource.com/1177421 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/5314945fa47aafd1edb930ace2590bdc7c874632/telemetry/telemetry/internal/browser/browser_options.py [add] https://crrev.com/5314945fa47aafd1edb930ace2590bdc7c874632/telemetry/telemetry/compact_mode_options.py [modify] https://crrev.com/5314945fa47aafd1edb930ace2590bdc7c874632/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9a53cfc55870d23c859cd8c534e381392eb015e commit a9a53cfc55870d23c859cd8c534e381392eb015e Author: Leonard Ge <wangge@google.com> Date: Fri Aug 17 14:16:23 2018 Avoid Adding Field Trial Flags If Flag is Set. This CL is a follow up CL of CL: 1174721. So we don't add field trial flag when the new compatibility mode flag is set. Bug: chromium:866881 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I5dae5a130445b9c61ad40cb13744a6272947424b Reviewed-on: https://chromium-review.googlesource.com/1175127 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Leonard Ge <wangge@google.com> Cr-Commit-Position: refs/heads/master@{#584057} [modify] https://crrev.com/a9a53cfc55870d23c859cd8c534e381392eb015e/tools/perf/core/perf_benchmark.py [modify] https://crrev.com/a9a53cfc55870d23c859cd8c534e381392eb015e/tools/perf/core/perf_benchmark_unittest.py
,
Dec 20
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nednguyen@chromium.org
, Jul 24