[Sync] PRESUBMIT broken after a change in sync.proto |
||
Issue descriptionThe PRESUBMIT script parses all data types from the specifics declaration in sync.proto. This is now broken and should be fixed.
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a87a02dec12e7d9b88c5d90f690786b79917177f commit a87a02dec12e7d9b88c5d90f690786b79917177f Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Jul 24 16:57:33 2018 [Sync] Adapt PRESUBMIT to a change in sync.proto The problem came with CL https://chromium-review.googlesource.com/c/chromium/src/+/1129140. Bug: 866876 Change-Id: I00c6a6464b6cd8a879c0c7bb72c03bc221137043 Reviewed-on: https://chromium-review.googlesource.com/1148388 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577585} [modify] https://crrev.com/a87a02dec12e7d9b88c5d90f690786b79917177f/components/sync/PRESUBMIT.py [modify] https://crrev.com/a87a02dec12e7d9b88c5d90f690786b79917177f/components/sync/PRESUBMIT_test.py
,
Aug 10
|
||
►
Sign in to add a comment |
||
Comment 1 by jkrcal@chromium.org
, Jul 24