New issue
Advanced search Search tips

Issue 866875 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Group all Blink Scheduler async slices together

Project Member Reported by kraynov@chromium.org, Jul 24

Issue description

We trace just too many states using tracing_helper.h,
so we should group all the rows together to improve trace readability.
 
Screenshot from 2018-07-24 14-18-45.png
62.1 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/f07f60ef0baab7680a5681d79ede6c9c4d20db46

commit f07f60ef0baab7680a5681d79ede6c9c4d20db46
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu Jul 26 12:12:25 2018

Drop Scheduler and FrameScheduler prefixes to save space.

It also groups Scheduler async slice rows while FrameSheduler
rows were already grouped, so prefixes are redundant.

Bug: chromium:866875
Change-Id: If5987b9e3b383deffda41f22b55969398fa50277
Reviewed-on: https://chromium-review.googlesource.com/1148459
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[add] https://crrev.com/f07f60ef0baab7680a5681d79ede6c9c4d20db46/tracing/tracing/extras/chrome/blink/blink_scheduler_async_slice_test.html
[modify] https://crrev.com/f07f60ef0baab7680a5681d79ede6c9c4d20db46/tracing/tracing/extras/chrome/blink/blink_scheduler_async_slice.html
[modify] https://crrev.com/f07f60ef0baab7680a5681d79ede6c9c4d20db46/tracing/tracing/model/async_slice_group_test.html

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f3418b8ea95005302e1d8f916d3adf87d01ae47

commit 2f3418b8ea95005302e1d8f916d3adf87d01ae47
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jul 26 14:11:28 2018

Roll src/third_party/catapult 42016a47fa2b..f07f60ef0baa (1 commits)

https://chromium.googlesource.com/catapult.git/+log/42016a47fa2b..f07f60ef0baa


git log 42016a47fa2b..f07f60ef0baa --date=short --no-merges --format='%ad %ae %s'
2018-07-26 kraynov@chromium.org Drop Scheduler and FrameScheduler prefixes to save space.


Created with:
  gclient setdep -r src/third_party/catapult@f07f60ef0baa

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866875
TBR=sullivan@chromium.org

Change-Id: Iaa63dd52d566926c5503ba449314f18d3e0a13c6
Reviewed-on: https://chromium-review.googlesource.com/1151208
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578288}
[modify] https://crrev.com/2f3418b8ea95005302e1d8f916d3adf87d01ae47/DEPS

Owner: ----
Status: Available (was: Assigned)
Components: Blink>Scheduling

Sign in to add a comment