New issue
Advanced search Search tips

Issue 866873 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

wpt_import.py blew up on non-ASCII string

Project Member Reported by foolip@chromium.org, Jul 24

Issue description

In https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21657 the import succeeded but the import notification step broke:

Traceback (most recent call last):
  File "/b/rr/tmp1rwdnB/w/src/third_party/blink/tools/wpt_import.py", line 27, in <module>
    main()
  File "/b/rr/tmp1rwdnB/w/src/third_party/blink/tools/wpt_import.py", line 20, in main
    host.exit(importer.main())
  File "/b/rr/tmp1rwdnB/w/src/third_party/blink/tools/blinkpy/w3c/test_importer.py", line 179, in main
    if not self.send_notifications(local_wpt, options.auto_file_bugs, options.monorail_auth_json):
  File "/b/rr/tmp1rwdnB/w/src/third_party/blink/tools/blinkpy/w3c/test_importer.py", line 654, in send_notifications
    dry_run=not auto_file_bugs, service_account_key_json=monorail_auth_json)
  File "/b/rr/tmp1rwdnB/w/src/third_party/blink/tools/blinkpy/w3c/import_notifier.py", line 72, in main
    bugs = self.create_bugs_from_new_failures(wpt_revision_start, wpt_revision_end, gerrit_url)
  File "/b/rr/tmp1rwdnB/w/src/third_party/blink/tools/blinkpy/w3c/import_notifier.py", line 193, in create_bugs_from_new_failures
    _log.info(str(bug))
  File "/b/rr/tmp1rwdnB/w/src/third_party/blink/tools/blinkpy/w3c/monorail.py", line 57, in __str__
    result += 'Description:\n{}\n'.format(self.body['description'])
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 8653: ordinal not in range(128)
step returned non-zero exit code: 1

 
Cc: -robertma@chromium.org
Owner: robertma@chromium.org
Status: Started (was: Available)
Sigh. Related to  issue 827502 . I missed logging back then.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70ff310b19bcbf06b77537f1c0194c7484671704

commit 70ff310b19bcbf06b77537f1c0194c7484671704
Author: Robert Ma <robertma@chromium.org>
Date: Tue Jul 24 22:58:11 2018

[blinkpy] Fix Unicode support in WPT Monorail wrapper

Summary and description of an issue may contain non-ASCII characters, so
we need to use `unicode(issue)` instead of `str(issue)` to stringify an
issue.

Bug:  866873 
Change-Id: I8d9a59c9c3864ccc21138b777dcf4e59637caf42
Reviewed-on: https://chromium-review.googlesource.com/1149010
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577719}
[modify] https://crrev.com/70ff310b19bcbf06b77537f1c0194c7484671704/third_party/blink/tools/blinkpy/w3c/import_notifier.py
[modify] https://crrev.com/70ff310b19bcbf06b77537f1c0194c7484671704/third_party/blink/tools/blinkpy/w3c/monorail.py
[modify] https://crrev.com/70ff310b19bcbf06b77537f1c0194c7484671704/third_party/blink/tools/blinkpy/w3c/monorail_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment