WebRtcRemoteEventLogManager::network_connection_tracker_ may be dereferenced when null |
||||||||
Issue descriptionIf a WebRtcRemoteEventLogManager object is destroyed before a profile is loaded (which triggers EnableForBrowserContext), the destructor can execute while network_connection_tracker_ is null; it should not be dereferenced in such a case.
,
Jul 24
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac6c0832b1d9f57442156cb846970d6353a0061b commit ac6c0832b1d9f57442156cb846970d6353a0061b Author: Elad Alon <eladalon@chromium.org> Date: Tue Jul 24 14:31:53 2018 Prevent null pointer dereferencing in WebRtcRemoteEventLogManager |network_connection_tracker_| might never be set (if no profile is loaded). In that case, it should not be dereferenced. Bug: 866865 Change-Id: I490be08795f41908d7ac49fdcd5d8588fbea83b7 Reviewed-on: https://chromium-review.googlesource.com/1148335 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577528} [modify] https://crrev.com/ac6c0832b1d9f57442156cb846970d6353a0061b/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
,
Jul 24
,
Jul 24
,
Jul 25
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25
Pls merge your change to M69 branch 3497 latest by 3:00 PM PT today, Wednesday (07/25/18). Thank you.
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f72dbcfe6c6d32cc8199d35d67e0b4af33819a0b commit f72dbcfe6c6d32cc8199d35d67e0b4af33819a0b Author: Elad Alon <eladalon@chromium.org> Date: Wed Jul 25 16:56:26 2018 Prevent null pointer dereferencing in WebRtcRemoteEventLogManager |network_connection_tracker_| might never be set (if no profile is loaded). In that case, it should not be dereferenced. Bug: 866865 Change-Id: I490be08795f41908d7ac49fdcd5d8588fbea83b7 Reviewed-on: https://chromium-review.googlesource.com/1148335 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577528}(cherry picked from commit ac6c0832b1d9f57442156cb846970d6353a0061b) Reviewed-on: https://chromium-review.googlesource.com/1149841 Reviewed-by: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#74} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/f72dbcfe6c6d32cc8199d35d67e0b4af33819a0b/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
,
Jul 27
,
Jul 31
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by eladalon@chromium.org
, Jul 24