Omnibox overlaps with status bar |
|||||||||||||
Issue descriptionApp Version: 70.0.3501.0 Canary iOS Version: 11.4.1, 12 Beta 4 Device: iPhone 8plus, iPhone 7plus, iPhone 7 Steps to reproduce: 1. Launch chrome 2. Change the device orientation to landscape 3. Open Bookmarks or reading list or recent tabs or history from new tab page 4. Change the device orientation to portrait 5. Tap on Done button and scroll the tab page Observed results: Notice that omnibox overlaps with status bar Expected results: Omnibox shouldn’t overlap with status bar Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes/No Bug reproducible after clearing cache and cookies: Yes/No Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA on M67 (UI refresh is available from M69) Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M69 Link to video: https://drive.google.com/file/d/19p6m7D3ODCexd3gqPesbbhfJcW8llPMh/view?usp=sharing
,
Jul 24
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfa5b989cbdee6924959baae352df25c7655eed1 commit bfa5b989cbdee6924959baae352df25c7655eed1 Author: Justin Cohen <justincohen@google.com> Date: Wed Jul 25 09:26:33 2018 [ios] Correct content suggestions safe area on rotation. Various safe area tweaks to correct the layout of fakebox on rotation when presented under another view controller. Bug: 866864 , 862208 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7fda5c1ae564825c203566add4c7e738bcb38eb8 Reviewed-on: https://chromium-review.googlesource.com/1149100 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577826} [modify] https://crrev.com/bfa5b989cbdee6924959baae352df25c7655eed1/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/bfa5b989cbdee6924959baae352df25c7655eed1/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Jul 25
,
Jul 26
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c29f093ac39dae4b6c3df7f78f7313dc2c787781 commit c29f093ac39dae4b6c3df7f78f7313dc2c787781 Author: Justin Cohen <justincohen@google.com> Date: Thu Jul 26 12:46:59 2018 [ios] Correct content suggestions safe area on rotation. Various safe area tweaks to correct the layout of fakebox on rotation when presented under another view controller. Bug: 866864 , 862208 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7fda5c1ae564825c203566add4c7e738bcb38eb8 Reviewed-on: https://chromium-review.googlesource.com/1149100 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577826}(cherry picked from commit bfa5b989cbdee6924959baae352df25c7655eed1) Reviewed-on: https://chromium-review.googlesource.com/1150701 Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#106} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/c29f093ac39dae4b6c3df7f78f7313dc2c787781/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/c29f093ac39dae4b6c3df7f78f7313dc2c787781/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Jul 31
Tested on 70.0.3508.0 Canary, iPhone 8Plus iOS 11.4 Omnibox overlaps with status bar for a second. https://drive.google.com/file/d/1zWh3ks-hZm7yUvgVe3U0mvkTEXpoUHMl/view
,
Aug 2
,
Aug 6
,
Aug 13
,
Aug 14
,
Aug 21
Given that this is mostly fixed (the view corrects itself as soon as -viewDidAppear is called), lowering the priority and marking this blocked by crbug.com/826369
,
Jan 10
This bug had an unsupported status. Updating to Untriaged so someone will reevaluate.
,
Jan 10
,
Jan 10
,
Jan 16
It doesn't seem to reproduce anymore. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by marq@chromium.org
, Jul 24Labels: q4
Owner: justincohen@chromium.org
Status: Assigned (was: Untriaged)