New issue
Advanced search Search tips

Issue 866860 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Bookmarks: Mobile Bookmarks folder disappears on app cold start

Project Member Reported by subhashi...@chromium.org, Jul 24

Issue description

App Version: 70.0.3501.0 Canary
iOS Version: 10.3.3, 11.4.1, 12.0 beta 4
Device: iPhone 6 Plus, iPhone 7 Plus, iPad Pro

Steps to reproduce:
1. Launch iOS Chrome
2. Go to Menu>Bookmarks
3. Force quit the app
4. Relaunch the app 
5. Go to Menu>Bookmarks

Observed results:
Mobile Bookmarks folder disappears 

Note: Mobile Bookmarks folder is shown after ‘5’ mins if the device is kept idle 

Expected results:
Should display mobile bookmarks folder immediately after app cold start

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on the current beta channel build : M69, Yes

Type-bug-regression? No

Link to video/image:
https://drive.google.com/open?id=1_3SzizYD9Anhm5OZhA-TX9CrUh4J5spm

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f254c80cc54f0612a895db475b47dc4011e56af5

commit f254c80cc54f0612a895db475b47dc4011e56af5
Author: sczs <sczs@chromium.org>
Date: Wed Jul 25 18:13:06 2018

[ios] Reloads Bookmark tableView after loading model.

Bug:  866860 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I321613158bac990345f01e46e34153eb84091411
Reviewed-on: https://chromium-review.googlesource.com/1148588
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577975}
[modify] https://crrev.com/f254c80cc54f0612a895db475b47dc4011e56af5/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm

Status: Fixed (was: Started)
Cc: subhashi...@chromium.org
Please verify on canary subhashinik@
Labels: Merge-TBD
Status: Verified (was: Fixed)
Verified in M70.0.3504.0 Canary in iPhone 8plus(iOS 11.4.1), iPhone 7(iOS 10.3.3) and iPad Air(iOS 11.4.1)

Mobile bookmarks folder now displays after app cold start

Link to video:
https://drive.google.com/file/d/1IKlAhIbFdchb3aNlK-rTyhR304QNiKfb/view?usp=sharing
Cc: kariahda@chromium.org
Labels: Merge-Request-69
kariahda@ please check for MergeApproval
Labels: -Merge-TBD -Merge-Request-69 Merge-Approved-69
Approved.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 27

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57897e91e667a61fbf4e17e717fe25680d6418ee

commit 57897e91e667a61fbf4e17e717fe25680d6418ee
Author: sczs <sczs@chromium.org>
Date: Fri Jul 27 23:22:36 2018

[ios] Reloads Bookmark tableView after loading model.

TBR=sczs@chromium.org

(cherry picked from commit f254c80cc54f0612a895db475b47dc4011e56af5)

Bug:  866860 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I321613158bac990345f01e46e34153eb84091411
Reviewed-on: https://chromium-review.googlesource.com/1148588
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577975}
Reviewed-on: https://chromium-review.googlesource.com/1154027
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#183}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/57897e91e667a61fbf4e17e717fe25680d6418ee/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm

Verified on iPhoneX , iPad Pro
iOS11.4.1, 12.0 beta#5
Mobile Bookmarks are displayed correctly on cold start.
Verified in:

App Version: 69.0.3497.0 beta
Devices: iPhone 7 PLus, iPhone 6 Plus, iPad Air
iOS Versions: 10.3.3, 11.4.1, 12.0 beta 5

Mobile bookmarks are displayed correctly on app cold start
Cc: sczs@chromium.org rohitrao@chromium.org
 Issue 866919  has been merged into this issue.

Sign in to add a comment