App crashes tapping on recently closed tab from Incognito mode |
||||||||
Issue descriptionApp Version: 69.0.3497.6 beta iOS Version:11.4.1, 12.0 beta 4 Devices: iPhone 6 Plus, iPhone 6S Plus Prerequisite: Have some recently closed tabs under Menu>Recent Tabs Steps to reproduce: 1. Launch iOS Chrome 2. Open a New Incognito tab 3. Go to Menu>Recent Tabs 4. Tap on any recently closed tab entry Observed results: App crashes Expected results: App should not crash Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on the current stable build :M67, No Bug reproducible on the current beta channel build :M68, Yes (crashes tapping on Menu>Recent Tabs) Type-bug-regression? No Link to Image/Video: https://drive.google.com/open?id=1bnEUCnrnI2CSBr3WfXKLKqODBDKh6Zk0 Crash Log: https://crash.corp.google.com/browse?stbtiq=df515239861ea7f1 STACK TRACE: Thread 0 (id: 0x303) CRASHED [EXC_BAD_ACCESS / KERN_INVALID_ADDRESS @ 0x00000000 ] MAGIC SIGNATURE THREAD Stack Quality61%Show frame trust levels 0x0000000100d4b4ac (Chrome -browser_view_controller.mm:4551 ) -[BrowserViewController restoreTabWithSessionID:] 0x0000000100d4b4a8 (Chrome -browser_view_controller.mm:4550 ) -[BrowserViewController restoreTabWithSessionID:] 0x0000000100e5b974 (Chrome -recent_tabs_table_view_controller.mm:892 ) -[RecentTabsTableViewController openTabWithTabRestoreEntry:] 0x0000000100e5a658 (Chrome -recent_tabs_table_view_controller.mm:620 ) -[RecentTabsTableViewController tableView:didSelectRowAtIndexPath:] 0x000000018c2a614c (UIKit + 0x0035014c ) 0x000000018c2f9dd0 (UIKit + 0x003a3dd0 ) 0x000000018c384af4 (UIKit + 0x0042eaf4 ) 0x000000018c37abc8 (UIKit + 0x00424bc8 ) 0x000000018c25f78c (UIKit + 0x0030978c ) 0x000000018233690c (CoreFoundation + 0x000ed90c ) __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ 0x0000000182334234 (CoreFoundation + 0x000eb234 ) __CFRunLoopDoObservers 0x0000000182334880 (CoreFoundation + 0x000eb880 ) __CFRunLoopRun 0x0000000182254da4 (CoreFoundation + 0x0000bda4 ) CFRunLoopRunSpecific 0x000000018423a01c (GraphicsServices + 0x0000b01c ) GSEventRunModal 0x000000018c2739c8 (UIKit + 0x0031d9c8 ) 0x000000010057d850 (Chrome -chrome_exe_main.mm:54 ) main 0x0000000181ce5fbc (libdyld.dylib + 0x00000fbc ) start
,
Jul 25
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79120700fd5c5fb080b70ddc803161a11189051b commit 79120700fd5c5fb080b70ddc803161a11189051b Author: sczs <sczs@chromium.org> Date: Thu Jul 26 01:37:24 2018 [ios] Fixes crash where restoring recently closed on incognito. RecentTabs was changed and it can now be opened from incognito, for this reason we now need to update restoreTabWithSessionID to make sure it always uses the non-incognito browserState. Bug: 866854 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifc7147df943997a1f0784af926ac95cf9735fdaa Reviewed-on: https://chromium-review.googlesource.com/1150579 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578161} [modify] https://crrev.com/79120700fd5c5fb080b70ddc803161a11189051b/ios/chrome/browser/ui/browser_view_controller.mm
,
Jul 26
,
Jul 26
,
Jul 27
Verified on Canary, Kariah PTAL
,
Jul 28
Approved!
,
Jul 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cb7e0f039793c63b43cbcfc66959cad10437ee6 commit 7cb7e0f039793c63b43cbcfc66959cad10437ee6 Author: sczs <sczs@chromium.org> Date: Sat Jul 28 00:46:31 2018 [ios] Fixes crash where restoring recently closed on incognito. RecentTabs was changed and it can now be opened from incognito, for this reason we now need to update restoreTabWithSessionID to make sure it always uses the non-incognito browserState. TBR=sczs@chromium.org (cherry picked from commit 79120700fd5c5fb080b70ddc803161a11189051b) Bug: 866854 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifc7147df943997a1f0784af926ac95cf9735fdaa Reviewed-on: https://chromium-review.googlesource.com/1150579 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578161} Reviewed-on: https://chromium-review.googlesource.com/1154142 Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#185} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/7cb7e0f039793c63b43cbcfc66959cad10437ee6/ios/chrome/browser/ui/browser_view_controller.mm
,
Jul 31
Verified in: App Version: 70.0.3508.0 canary Devices: iPhone 7 Plus, iPhone 6 Plus, iPad Pro, iPad Air iOS Versions: 10.3.3, 11.4.1, 12.0 beta 5 Issue is fixed. No crashes seen tapping on recently closed tab from incognito.
,
Aug 1
Verified in: App Version: 69.0.3497.0 beta Devices: iPhone 7 Plus, iPhone 6 Plus, iPad Air iOS Versions: 10.3.3, 11.4.1, 12.0 beta 5 Issue is fixed. No crashes seen tapping on recently closed tab from incognito. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by marq@chromium.org
, Jul 24Labels: Q2 M-69
Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)