New issue
Advanced search Search tips

Issue 866823 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
nyerramilli@chromium.org
r...@igalia.com
rbasuvula@chromium.org
e...@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Movement of Page contents('Google','Term','Privacy','Google apps icon','Profile icon'..) is seen when clicked on Eye icon(Show Password).

Reported by shruti.j...@etouch.net, Jul 24 
Chrome Version:70.0.3501.0 (Official Build)  Revision	5437941df764183b1776e37da065505ad660f1c0-refs/branch-heads/3501@{#1}(64-bit)

OS: Mac(10.12.6, 10.13.1, 10.13.6, 10.14).

Pre-condition:There must be at-least two password saved in google account.

Steps to reproduce:
1. Launch chrome and navigate to chrome://settings/password.
2. Click on 'Google Account' and login with valid credentials.
3. Click on Eye icon (Show Password) and observe.

Actual Result:  Movement of Page contents('Google','Term','Privacy','Google apps icon','Profile icon'..) is seen when clicked on Eye icon(Show Password).
Expected Result: No such Toggling of Page contents should be seen when clicked on Eye icon(Show Password).

This is a regression issue, broken in 'M-70', and below is the bisect provided using per-revision script.
Good Build:70.0.3498.0 (Revision: 577007)
Bad Build: 70.0.3499.0 (Revision: 577086)

You are probably looking for a change made after 577029 (known good), but no later than 577030 (first known bad).

CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/025c4917a3d0a3420ec520807c348741988102ac..db71b93784806ce5e46bdadd494c472858f21d43

Suspect: https://chromium.googlesource.com/chromium/src/+/db71b93784806ce5e46bdadd494c472858f21d43

@Manuel Rego Casasnovas : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is Mac specific and is not reproducible on Windows(7,8,8.1,10) and Linux(14.04 LTS).

Kindly refer the screen-cast using the below given link.

https://drive.google.com/open?id=1CAmDZM0BInDNs5ydEbsiu6lwX0JECUPp

Thank You.

Comment 1 by r...@igalia.com, Jul 27

Cc: e...@chromium.org
Sorry but I didn't have time this week to take a look to this from a Mac, I'll try to do it next week.

I don't see the issue happening on Linux.

If the regression started on that patch, probably the settings code needs to be updated to avoid using "contain: layout" in some situation.
As from now on "contain: layout" elements will become containing blocks for positioned descendants, as described in the spec.

Comment 2 by r...@igalia.com, Jul 30

Cc: r...@igalia.com
Owner: ----
Status: Available (was: Assigned)
I managed to reproduce this on a Mac.

Despite I don't know the real cause of the problem,
I've been checking that it's related to layout containment.

If you remove "contain: layout" from c-wiz elements, then the issue is gone.
Try to use this CSS:
  c-wiz {
    contain: style;
  }
And the issue is not reproducible.

As I said now "contain: layout" elements are containing blocks for positioned descendants
and that might be causing some variations on the expected behavior.

Unless you can provide a reduced test case I believe the issue is in the app itself
and it might need to get updated somehow (maybe using less layout containment as suggested before).

I don't know the reason why it only happens in Mac, but it might be related with the extra layouts
(or calls to compute intrinsic widths) Mac runs sometimes, but don't happen on other platforms.
►

Sign in to add a comment