DCHECK hit when signing out |
||
Issue descriptionWith Unified Consent flag. What steps will reproduce the problem? (1) Sign in (2) Go to settings > my account > Sign out of Chrome What is the expected result? No DCHECK hit. What happens instead? DCHECK hit. Continuing the execution works as expected.
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06477a0b61e2b4f445aea0e518439729abf59e7c commit 06477a0b61e2b4f445aea0e518439729abf59e7c Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Jul 24 12:23:01 2018 [Identity] Fixing DCHECK when signing out Need to use gaia::AreEmailsSame() instead of comparing emails directly. Also, DCHECK_EQ() should be used instead of DCHECK(). Bug: 866801 Change-Id: I229e6aef631dca1f6ecf4c0242a11db15687d25a Reviewed-on: https://chromium-review.googlesource.com/1148206 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577489} [modify] https://crrev.com/06477a0b61e2b4f445aea0e518439729abf59e7c/services/identity/public/cpp/identity_manager.cc
,
Jul 24
|
||
►
Sign in to add a comment |
||
Comment 1 by gambard@chromium.org
, Jul 24