New issue
Advanced search Search tips

Issue 866793 link

Starred by 2 users
Status: Fixed
Owner:
yawano@chromium.org
Closed: Jul 30
Cc:
dtseng@chromium.org
lpalmaro@chromium.org
sarakato@chromium.org
yawano@chromium.org
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Keyboard navigation is not working with TalkBack on Android window

Project Member Reported by yawano@chromium.org, Jul 24 
Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) Open any Android window.
(2) Try to navigate with TalkBack by using keyboard.
(3) It doesn't work.

Additional information.
We need to properly update kAccessibilityFocusFallsbackToWidgetKey depending on whether TalkBack or ChromeVox is used for the window. This corresponds to the following TODO.

https://cs.chromium.org/chromium/src/components/exo/shell_surface_base.cc?l=1189&rcl=f09b898143cb3102ac468d4f968d2a385659c05b
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb4ffc9abbfd2f37a44aed12d631bf254754a436

commit fb4ffc9abbfd2f37a44aed12d631bf254754a436
Author: Yuki Awano <yawano@chromium.org>
Date: Fri Jul 27 02:24:46 2018

Update kAccessibilityFocusFallsbackToWidgetKey

- Update kAccessibilityFocusFallsbackToWidgetKey depending on whether
  ChromeVox or TalkBack is used for the window.
- This CL fixes the logic to update window properties. AxTree can arrive
  to the helper bridge after a window is activated. This CL adds a logic
  to fix it.

      confirm that it works.

Bug:  866793 
Test: Navigate Android window with TalkBack by using keyboard and
Change-Id: I911c77229c9a6f338fcdadd81ea5642aaefae084
Reviewed-on: https://chromium-review.googlesource.com/1148099
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578521}
[modify] https://crrev.com/fb4ffc9abbfd2f37a44aed12d631bf254754a436/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/fb4ffc9abbfd2f37a44aed12d631bf254754a436/components/exo/shell_surface_base.cc

Comment 2 by yawano@chromium.org, Jul 27

Labels: Merge-Request-69
Request a CL in comment 1 merge to M69.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 28

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 30

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2046367d029109d112542df296a8ac8627bb6570

commit 2046367d029109d112542df296a8ac8627bb6570
Author: Yuki Awano <yawano@chromium.org>
Date: Mon Jul 30 02:02:56 2018

Update kAccessibilityFocusFallsbackToWidgetKey

- Update kAccessibilityFocusFallsbackToWidgetKey depending on whether
  ChromeVox or TalkBack is used for the window.
- This CL fixes the logic to update window properties. AxTree can arrive
  to the helper bridge after a window is activated. This CL adds a logic
  to fix it.

      confirm that it works.

Bug:  866793 
Test: Navigate Android window with TalkBack by using keyboard and
Change-Id: I911c77229c9a6f338fcdadd81ea5642aaefae084
Reviewed-on: https://chromium-review.googlesource.com/1148099
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578521}(cherry picked from commit fb4ffc9abbfd2f37a44aed12d631bf254754a436)
Reviewed-on: https://chromium-review.googlesource.com/1154648
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#199}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2046367d029109d112542df296a8ac8627bb6570/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/2046367d029109d112542df296a8ac8627bb6570/components/exo/shell_surface_base.cc

Comment 5 by yawano@chromium.org, Jul 30 

Merged the CL to M69 branch.

Comment 6 by yawano@chromium.org, Jul 30

Status: Fixed (was: Assigned)
►

Sign in to add a comment