New issue
Advanced search Search tips

Issue 866785 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

fast/forms/select/select-initial-position.html and 6 other(s) in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.13 (retina)

Project Member Reported by hajimehoshi@chromium.org, Jul 24

Issue description

fast/forms/select/select-initial-position.html and 6 other(s) in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.13 (retina)

Builders failed on: 
- WebKit Mac10.13 (retina): 
  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29


 
Cc: rsesek@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/112e1c4addd5036f658dbe2f3df789a1a118137d

commit 112e1c4addd5036f658dbe2f3df789a1a118137d
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Jul 24 08:12:00 2018

Fix TestExpectaitons for failing tests on Mac Retina

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/?limit=200
The tests have been failing for a long time

TBR: hajimehoshi@chromium.org
Bug:  866785 
Change-Id: Ia884e0aca4fcbb2c8ab47f38cf5ea48c2f22538f
Reviewed-on: https://chromium-review.googlesource.com/1148081
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577455}
[modify] https://crrev.com/112e1c4addd5036f658dbe2f3df789a1a118137d/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b166a1b60efb899ead3128eaf91df6620b5629c

commit 6b166a1b60efb899ead3128eaf91df6620b5629c
Author: Derek Cheng <imcheng@chromium.org>
Date: Wed Jul 25 21:39:20 2018

[Sheriff] Update expectations for a few layout tests.

virtual/user-activation-v2/fast/events/middleClickAutoscroll-click-hyperlink.html
virtual/user-activation-v2/fast/events/middleClickAutoscroll-nested-divs-forbidden.html
virtual/new-remote-playback-pipeline/media/controls/text-track-menu-pointer-selection.html

Tbr: hajimehoshi
Bug:  866785 , 867628 
Change-Id: I938fe40c98ffbad9ef697556bcb456243b8b50da
Reviewed-on: https://chromium-review.googlesource.com/1150697
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578073}
[modify] https://crrev.com/6b166a1b60efb899ead3128eaf91df6620b5629c/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium Test-Flaky
Components: -Blink>Layout Blink>Forms
Components: -Blink>Forms Blink>Forms>Select
Labels: -Test-Flaky
Status: Available (was: Untriaged)
Though the regression range is obvious [1], I couldn't find suspicious changes in it.  Anyway, it looks we may do rebaseline.

[1] https://test-results.appspot.com/revision_range?start=577980&end=578017

Components: -Blink>Forms>Select Blink>Layout
Owner: kojii@chromium.org
Status: Assigned (was: Available)
Oh, the following CL must be the culprit:
https://chromium.googlesource.com/chromium/src/+/9054bba778fee1821d992d44d3fdcf8de7cecb33

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bcddb53f52516d685ab55b2f4a091057e75d3f6

commit 0bcddb53f52516d685ab55b2f4a091057e75d3f6
Author: Koji Ishii <kojii@chromium.org>
Date: Wed Aug 01 07:06:25 2018

Re-rebaseline 8 tests failing on Mac

Re-ran rebaseline-cl. Somehow this produced different results
from the last run in CL:1142048.

Bug:  866785 
Change-Id: I02c9ebc5fd206a20ff5c8bf919bd51eaeaef3e10
Reviewed-on: https://chromium-review.googlesource.com/1156338
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579716}
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/select-initial-position-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/select-initial-position-expected.txt
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/parser/001-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/table/backgr_border-table-quirks-collapsed-border-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/table/backgr_border-table-quirks-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/select-initial-position-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/select-initial-position-expected.txt
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/table/backgr_border-table-quirks-collapsed-border-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/table/backgr_border-table-quirks-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac-mac10.12/svg/as-border-image/svg-as-border-image-2-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac-mac10.12/svg/as-border-image/svg-as-border-image-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/select-initial-position-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/select-initial-position-expected.txt
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac/fast/parser/001-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac/fast/parser/001-expected.txt
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac/fast/table/backgr_border-table-quirks-collapsed-border-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac/fast/table/backgr_border-table-quirks-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac/svg/as-border-image/svg-as-border-image-2-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac/svg/as-border-image/svg-as-border-image-2-expected.txt
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac/svg/as-border-image/svg-as-border-image-expected.png
[modify] https://crrev.com/0bcddb53f52516d685ab55b2f4a091057e75d3f6/third_party/WebKit/LayoutTests/platform/mac/svg/as-border-image/svg-as-border-image-expected.txt

Status: Fixed (was: Assigned)
Hope it works this time.

Sign in to add a comment