Text input doesn't work on Android apps. |
||
Issue descriptionI changed the implementation of IsInArcAppWindow() in crrev.com/c/1146626 and the new implementation assumes the checked window is already attached to window hierarchy. However, we use the method in OnWindowInitialized() and in that method, a created window is not attached to window tree yet. It prevents ArcImeService from registering FocusObserver. I'm working on fix now.
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e046a6ea519c0f67fdcec728c13741103db64056 commit e046a6ea519c0f67fdcec728c13741103db64056 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Tue Jul 24 07:58:24 2018 Revert "Cleanup IsArcAppWindow() in ArcWindowDelegateImpl." This reverts commit ce0157f4edc1ec161915f859b0529c2b8e7e3bd6. Reason for revert: This change breaks text input on ARC windows. Bug: 866784 Original change's description: > Cleanup IsArcAppWindow() in ArcWindowDelegateImpl. > > Now aura::client::kAppType property is set for an ARC notification > window. We can use it for check. > > Change-Id: Id27f5ab83492a4c1a517b1350ae1fc30bfbf8fae > Reviewed-on: https://chromium-review.googlesource.com/1146626 > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577422} TBR=yusukes@chromium.org,yhanada@chromium.org Change-Id: I9a58768a0ae0d84d13d9943674ed60954a9b39d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1148120 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#577451} [modify] https://crrev.com/e046a6ea519c0f67fdcec728c13741103db64056/components/arc/ime/arc_ime_service.cc [modify] https://crrev.com/e046a6ea519c0f67fdcec728c13741103db64056/components/arc/ime/arc_ime_service.h [modify] https://crrev.com/e046a6ea519c0f67fdcec728c13741103db64056/components/arc/ime/arc_ime_service_unittest.cc
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51b8e60e32fbb3d79a2e3e5ab09dadfba16b3889 commit 51b8e60e32fbb3d79a2e3e5ab09dadfba16b3889 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Thu Jul 26 01:38:49 2018 Register FocusObserver in the constructor of ArcImeService. ash::Shell is created in PreProfileInit() step and ArcImeService is started in PostProfileInit() step, so it is safe to register FocusObserver in the constructor of ArcImeService. This CL also cleans up IsExoWindow() and IsArcWindow() in ArcWindowDelegateImpl. Bug: 866784 Test: browser_tests, components_unittests Change-Id: I3bd32f4e888f86cbd215791e559901e1457694e2 Reviewed-on: https://chromium-review.googlesource.com/1148089 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#578162} [modify] https://crrev.com/51b8e60e32fbb3d79a2e3e5ab09dadfba16b3889/components/arc/ime/arc_ime_service.cc [modify] https://crrev.com/51b8e60e32fbb3d79a2e3e5ab09dadfba16b3889/components/arc/ime/arc_ime_service.h [modify] https://crrev.com/51b8e60e32fbb3d79a2e3e5ab09dadfba16b3889/components/arc/ime/arc_ime_service_unittest.cc
,
Jul 26
|
||
►
Sign in to add a comment |
||
Comment 1 by yhanada@chromium.org
, Jul 24