New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 866782 link

Starred by 10 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 0
Type: Bug-Regression



Sign in to add a comment

Regression:Browser gets crashed after clicking on secure lock icon.

Reported by vineetha...@etouch.net, Jul 24

Issue description

Chrome version : 70.0.3501.0 (Official Build) 5437941df764183b1776e37da065505ad660f1c0-refs/branch-heads/3501@{#1}(32/64-bit) 
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome , navigate to www.google.com.
2. Click on the secure chip(lock icon) to the L.H.S of omnibox and observe.

Actual  : Browser gets crashed after clicking on secure lock icon.
Expected: Browser should not get crashed after clicking on secure lock icon.

This is a regression issue broken in ‘M-70’ and will soon provide other info.
Good build: 70.0.3500.0
Bad build: 70.0.3501.0

Uploaded Crash Report ID d07c61dca9d2501e (Local Crash ID: a7070410-0aba-43bf-907c-ac9361a50636)
 
Actual Result.mp4
658 KB View Download
Expected Result.mp4
292 KB View Download
Labels: RegressedIn-70 hasbisect
Owner: proberge@chromium.org
Status: Assigned (was: Unconfirmed)
Update:

Unable to provide bisect using per-revision script since getting error while bisecting, hence re-bisected with old script: 

Narrow Bisect info : 

https://chromium.googlesource.com/chromium/src/+log/f8ffab5d79243cb7de978d17669e8decdb9141df..05d77a1fbd1e5c3aa15468e0c4ea833fe67a9b9a?pretty=fuller&n=10000

Suspect: r577346 ?

@proberge: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is Windows OS specific and is not reproducible on Mac and Linux OS.

Thank You!
Cc: proberge@chromium.org gov...@chromium.org abdulsyed@chromium.org ajha@chromium.org ligim...@chromium.org
Labels: -Pri-1 ReleaseBlock-Dev Pri-0
Owner: reillyg@chromium.org
Please find the stack trace for the crash:
------------------------------------------
Thread 35 (id: 0x874) CRASHED [EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000010 ] MAGIC SIGNATURE THREAD
Stack Quality100%Show frame trust levels
0x000007fedf9bb365	(chrome.dll -core.c:1339 )	libusb_close
0x000007fedfe876d3	(chrome.dll -scoped_libusb_device_handle.cc:28 )	device::ScopedLibusbDeviceHandle::Reset()
0x000007fedfe87690	(chrome.dll -scoped_libusb_device_handle.cc:24 )	device::ScopedLibusbDeviceHandle::~ScopedLibusbDeviceHandle()
0x000007fedf9bde3c	(chrome.dll -usb_device_impl.cc:119 )	device::UsbDeviceImpl::OpenOnBlockingThread(base::OnceCallback<void >,scoped_refptr<base::TaskRunner>,scoped_refptr<base::SequencedTaskRunner>)
0x000007fedf9be040	(chrome.dll -bind_internal.h:649 )	base::internal::Invoker<base::internal::BindState<void (device::UsbDeviceImpl::*)(base::OnceCallback<void (scoped_refptr<device::UsbDeviceHandle>)>, scoped_refptr<base::TaskRunner>, scoped_refptr<base::SequencedTaskRunner>),scoped_refptr<device::UsbDeviceImpl>,base::OnceCallback<void (scoped_refptr<device::UsbDeviceHandle>)>,scoped_refptr<base::SingleThreadTaskRunner>,scoped_refptr<base::SequencedTaskRunner> >,void ()>::RunOnce
0x000007feddc74beb	(chrome.dll -task_annotator.cc:101 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *)
0x000007feddcf8e3d	(chrome.dll -task_tracker.cc:529 )	base::internal::TaskTracker::RunOrSkipTask(base::internal::Task,base::internal::Sequence *,bool)
0x000007feddcf8925	(chrome.dll -task_tracker.cc:404 )	base::internal::TaskTracker::RunAndPopNextTask(scoped_refptr<base::internal::Sequence>,base::internal::CanScheduleSequenceObserver *)
0x000007feddcf7671	(chrome.dll -scheduler_worker.cc:329 )	base::internal::SchedulerWorker::RunWorker()
0x000007feddcf72ef	(chrome.dll -scheduler_worker.cc:224 )	base::internal::SchedulerWorker::RunPooledWorker()
0x000007fedee4ccb3	(chrome.dll -platform_thread_win.cc:91 )	base::`anonymous namespace'::ThreadFunc
0x774759cc	(KERNEL32.dll + 0x000159cc )	BaseThreadInitThunk
0x7770b980	(ntdll.dll + 0x0002b980 )	RtlUserThreadStart

1)This crash is first started on latest canary 70.0.3501.0 and seeing 68 from 65 different clients.
2)This crash seen on Windows>Browser and it is in 1st rank position.
3)This crash not seen on latest Dev,Beta & Stable builds.

70.0.3501.1	1.25%	1
70.0.3501.0	98.75%	79

Link to the list of builds:
---------------------------
https://crash.corp.google.com/browse?q=product_name%3D%27Chrome%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27libusb_close%27

As per code search "scoped_libusb_device_handle.cc"

Change log:
-----------
https://chromium.googlesource.com/chromium/src/+log/96e7e0b037345fc2b76d8a7f1cf039c64074c67e/device/usb/scoped_libusb_device_handle.cc

Change URL:
-----------
https://chromium.googlesource.com/chromium/src/+/daa348fab9cae0919ebe9ded50782c6f7aa38be5

@reillyg : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
Cc: reillyg@chromium.org
 Issue 866788  has been merged into this issue.
Suspected CL has been reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1147950.
Status: Fixed (was: Assigned)
I have reverted r577329.
 Issue 866907  has been merged into this issue.
Issue 866905 has been merged into this issue.
Thanks for reverting Reilly! Canary is super crashy because of this. Tried to track down why the crash and say your revert:)
Pls merge the revert to canary branch 3501 so we can trigger canary from same branch as today's canary is super crashy due to this bug. Thank you.
Thank you reillyg@ for the merge to 3501 branch - https://chromium.googlesource.com/chromium/src.git/+/4d2a4e764bc7c436e06ba6f65cf53d5202db6ec9. Triggering new canary for Desktop from same branch now.
Canary #70.0.3501.2 successfully deployed which includes revert listed at #2. Pls verify the bug. Thank you.
 Issue 866844  has been merged into this issue.
Labels: TE-Verified-M70 TE-Verified-70.0.3501.2
Able to reproduce the issue on Win-10 using chrome reported version #70.0.3501.0.

Verified the fix on Win-10 using Chrome version #70.0.3501.2 as per the comment #0.
Attaching screen cast for reference.
Observed that Browser did not get crash after clicking on secure lock icon.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
866782.mp4
280 KB View Download
Issue 867061 has been merged into this issue.
Cc: dtapu...@chromium.org
 Issue 867284  has been merged into this issue.

Sign in to add a comment