New issue
Advanced search Search tips

Issue 866778 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Regression : Unnecessary search result is seen in search field after pressing 'Enter' key continuously in chrome://settings/ page

Reported by rp...@etouch.net, Jul 24 
Chrome version: 70.0.3500.0 (Official Build)Revision 19fb8c745affb4c0f621296e66bac6094e692076-refs/branch-heads/3500@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6)

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://settings/
2. Now click on 'Passwords' and select 'Saved passwords will appear here' using mouse cursor and drag it to 'Search settings' search field.
3. Now click on 'Clear search' button and again click on 'Passwords' and press 'Enter' key continuously,observe
 
Actual: Unnecessary search result is seen in 'search settings' search field after pressing 'Enter' key continuously
Expected: Unnecessary search result shouldn't be seen in 'search settings' search field after pressing 'Enter' key continuously

This is regression issue, broken in ‘M 69’ and below is the bisect info :
Good build: 69.0.3483.0  (Revision: 572880).
Bad build: 69.0.3484.0 (Revision: 573141).

You are probably looking for a change made after 573024(known good), but no later than 573025(first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/319dccb73e550b6348f6b7f8e67536cd57e419f8..4fe015851ebc02d18736490caf5db3e42f29884e

Suspect: https://chromium.googlesource.com/chromium/src/+/4fe015851ebc02d18736490caf5db3e42f29884e

@dpapad: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!
Actual_video.mp4
454 KB View Download
Expected_video.mp4
429 KB View Download

Comment 1 by dpa...@chromium.org, Jul 25

Labels: -Pri-1 -Type-Bug-Regression Pri-3 Type-Bug
Owner: ----
Status: Available (was: Assigned)
The CL at r573025, fixed focusing when exiting a subpage which in turn revealed this bug, but it does not otherwise cause this bug (it can be reproduced by manually focusing the back button and holding down the enter key).

This happens because while holding the "enter" button the navigateToPreviousRoute call at [1] is executed multiple times. Should be fixable by adding some sort of de-bouncing when handling the key event. 

Lowering priority since holding down the key is not a frequent user case.


[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settings_page/settings_subpage.js?q=settings_subpage.js&g=0&l=85
►

Sign in to add a comment