the 1.5.x release is old. the 1.6.x is less old. time to update.
Let me know if you need help testing that the update doesn't break the Android build, I'll be happy to contribute.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b1b1ba40ff0576d090811aaed0dbe14de4d025c commit 7b1b1ba40ff0576d090811aaed0dbe14de4d025c Author: Mike Frysinger <vapier@chromium.org> Date: Tue Jul 24 13:50:47 2018 grit: strip trailing blank lines Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: Iacfd1dcb0eb16d33aa5cf382aecb5b1dd4e7efa7 Reviewed-on: https://chromium-review.googlesource.com/1147717 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#577512} [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/__init__.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/clique.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/extern/tclib.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/format/__init__.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/gather/regexp.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/gather/tr_html.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/gather/txt_unittest.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/node/base.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/node/base_unittest.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/node/custom/filename_unittest.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/node/io.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/node/mapping.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/node/structure.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/node/variant.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/pseudo.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/shortcuts.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/shortcuts_unittests.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/__init__.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/android2grd.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/count.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/menu_from_parts.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/postprocess_interface.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/postprocess_unittest.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/preprocess_interface.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/preprocess_unittest.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/rc2grd.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/rc2grd_unittest.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/test.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/tool/transl2tc.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/util_unittest.py [modify] https://crrev.com/7b1b1ba40ff0576d090811aaed0dbe14de4d025c/tools/grit/grit/xtb_reader.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41ff8336afca01acc14f85ad4f6fee037cc25a27 commit 41ff8336afca01acc14f85ad4f6fee037cc25a27 Author: Mike Frysinger <vapier@chromium.org> Date: Tue Jul 24 16:53:06 2018 ppapi: generators: strip trailing blank lines Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: I20739c2086c1fac0a802c07e9f4baa5f8bbf4291 Reviewed-on: https://chromium-review.googlesource.com/1148000 Reviewed-by: Brad Nelson <bradnelson@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#577582} [modify] https://crrev.com/41ff8336afca01acc14f85ad4f6fee037cc25a27/ppapi/generators/idl_ast.py [modify] https://crrev.com/41ff8336afca01acc14f85ad4f6fee037cc25a27/ppapi/generators/idl_c_header.py [modify] https://crrev.com/41ff8336afca01acc14f85ad4f6fee037cc25a27/ppapi/generators/idl_namespace.py [modify] https://crrev.com/41ff8336afca01acc14f85ad4f6fee037cc25a27/ppapi/generators/idl_node.py [modify] https://crrev.com/41ff8336afca01acc14f85ad4f6fee037cc25a27/ppapi/generators/idl_parser.py [modify] https://crrev.com/41ff8336afca01acc14f85ad4f6fee037cc25a27/ppapi/generators/idl_propertynode.py [modify] https://crrev.com/41ff8336afca01acc14f85ad4f6fee037cc25a27/ppapi/generators/idl_release.py [modify] https://crrev.com/41ff8336afca01acc14f85ad4f6fee037cc25a27/ppapi/generators/idl_tests.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8944dc9781df692dde4e0e49acf5b7605080a58 commit a8944dc9781df692dde4e0e49acf5b7605080a58 Author: Mike Frysinger <vapier@chromium.org> Date: Tue Jul 24 17:10:31 2018 build: android: strip trailing blank lines Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: Ib0f353d83dd0b86ac0b304c5704a9725867846b2 Reviewed-on: https://chromium-review.googlesource.com/1147719 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#577591} [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/devil_chromium.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/gyp/generate_resource_rewriter.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/gyp/java_google_api_keys.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/gyp/main_dex_list.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/gyp/util/__init__.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/gyp/write_ordered_libraries.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/incremental_install/__init__.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/method_count.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/android/__init__.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/base/__init__.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/base/base_test_result.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/base/test_exception.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/base/test_instance.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/base/test_run.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/base/test_run_factory.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/base/test_server.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/gtest/__init__.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/gtest/gtest_test_instance.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/gtest/gtest_test_instance_test.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/instrumentation/__init__.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/junit/__init__.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/linker/__init__.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/linker/linker_test_instance.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/local/local_test_server_spawner.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/results/json_results.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/results/json_results_test.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/utils/logdog_helper.py [modify] https://crrev.com/a8944dc9781df692dde4e0e49acf5b7605080a58/build/android/pylib/valgrind_tools.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6 commit 15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6 Author: Mike Frysinger <vapier@chromium.org> Date: Tue Jul 24 23:14:51 2018 trim trailing blank lines Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: I04aa0d35e6dc96150699e947ea4449a8b9dd1cb1 Reviewed-on: https://chromium-review.googlesource.com/1147715 Reviewed-by: Joey Scarr <jsca@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/unittests/recipe_lint_test.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipes/bisection/android_bisect_staging.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipe_modules/disk/api.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/master/buildbucket/trigger.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/master/factory/dart/pub_poller.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipe_modules/chromium_tests/tests/steps/mock_test.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipe_modules/test_results/config.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/masters/master.client.v8/mail_notifier_cfg.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipes/v8/auto_roll_push.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipes/bisection/android_bisect.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipe_modules/crrev/api.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/tools/loggrep.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipes/remote_run_test.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipe_modules/crrev/resources/crrev_client_test.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipe_modules/legion/examples/full.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/master/try_job_gerrit.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipe_modules/cronet/examples/full.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipe_modules/commit_position/api.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/common/gerrit/query.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipes/annotated_run_test.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/site_config/config.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipe_modules/chromium_tests/tests/api/runhooks.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/masters/master.client.v8.branches/mail_notifier_cfg.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipes/webrtc/auto_roll_webrtc_deps.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/recipe_modules/chromium/tests/get_version.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/common/twisted_util/body_producers.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/scripts/slave/crash_utils.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/masters/master.chromium.memory/master_mac_cfg.py [modify] https://crrev.com/15d2dbafa15a0a1d07c273d31fee99e5d0c56cf6/masters/master.chromium.webrtc/master_builders_cfg.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/61c28435aed345e8efbfb459aa0c6ffb88d3c56e commit 61c28435aed345e8efbfb459aa0c6ffb88d3c56e Author: Mike Frysinger <vapier@chromium.org> Date: Thu Jul 26 22:52:06 2018 lint: disable consider-iterating-dictionary class The new pylint-1.6 will warn whenever you use the form: for key in foo.keys(): (where |foo| is a dictionary.) In our code base, we trip this about 10 times, and only one of which we should be using .items(). Disable the warning until pylint is a bit smarter -- it should only warn if the body of code actually does something like foo[key] vs only using the keys in the loop. BUG=chromium:866772 TEST=`cros lint` is unchanged in here Change-Id: Iced26412ab8da8218a3edcdd9fa3d6ca4c83cd0c Reviewed-on: https://chromium-review.googlesource.com/1149102 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/61c28435aed345e8efbfb459aa0c6ffb88d3c56e/pylintrc [modify] https://crrev.com/61c28435aed345e8efbfb459aa0c6ffb88d3c56e/lib/cts_helper.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/3fff4ff387013909c6730744773e97f991444f54 commit 3fff4ff387013909c6730744773e97f991444f54 Author: Mike Frysinger <vapier@chromium.org> Date: Fri Jul 27 03:45:08 2018 lint: fix ungrouped-imports warnings Since this only shows up in two modules, fix the warning. BUG=chromium:866772 TEST=`cros lint` doesn't show anymore Change-Id: I0b06f1bea198220a0042d799c41378fd7ada2b8d Reviewed-on: https://chromium-review.googlesource.com/1149108 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Gregory Meinke <gmeinke@chromium.org> [modify] https://crrev.com/3fff4ff387013909c6730744773e97f991444f54/scripts/cros_portage_upgrade.py [modify] https://crrev.com/3fff4ff387013909c6730744773e97f991444f54/scripts/upload_symbols.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5598ef19acaa4c55a284c120e8137e39f5d6b85 commit e5598ef19acaa4c55a284c120e8137e39f5d6b85 Author: Mike Frysinger <vapier@chromium.org> Date: Tue Jul 31 17:18:34 2018 cr: strip trailing blank lines Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: I34e4325d071fde874558cee68c0460ecde5023c7 Reviewed-on: https://chromium-review.googlesource.com/1147718 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#579447} [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/actions/action.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/actions/builder.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/actions/gdb.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/actions/linux.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/actions/runner.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/base/android.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/base/buildtype.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/base/client.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/commands/command.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/commands/info.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/commands/prepare.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/commands/run.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/fixups/arch.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/targets/chrome_public.py [modify] https://crrev.com/e5598ef19acaa4c55a284c120e8137e39f5d6b85/tools/cr/cr/visitor.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/0444f4c574142e2fb2394fc13b0bd3a9d8641e0e commit 0444f4c574142e2fb2394fc13b0bd3a9d8641e0e Author: Mike Frysinger <vapier@chromium.org> Date: Sun Aug 05 03:09:26 2018 lint: fix old style octal constants In the case of parallel_emerge, we were actually using a decimal number. BUG=chromium:866772 TEST=cros lint shows nothing new Change-Id: I7059fbceacd88b4ef9c75a788ccaaf7a29e48aa4 Reviewed-on: https://chromium-review.googlesource.com/1162645 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Gregory Meinke <gmeinke@chromium.org> [modify] https://crrev.com/0444f4c574142e2fb2394fc13b0bd3a9d8641e0e/lib/cipd.py [modify] https://crrev.com/0444f4c574142e2fb2394fc13b0bd3a9d8641e0e/lib/gs_unittest.py [modify] https://crrev.com/0444f4c574142e2fb2394fc13b0bd3a9d8641e0e/cros/test/image_test.py [modify] https://crrev.com/0444f4c574142e2fb2394fc13b0bd3a9d8641e0e/scripts/parallel_emerge.py [modify] https://crrev.com/0444f4c574142e2fb2394fc13b0bd3a9d8641e0e/scripts/cros_vm.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b955903bed7c037e90beba90b19aa3bc392f959a commit b955903bed7c037e90beba90b19aa3bc392f959a Author: Mike Frysinger <vapier@chromium.org> Date: Wed Sep 12 22:28:39 2018 chrome_proxy: strip trailing blank lines Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: Ic8fc7a7d01ab9ee85ee6cecb98743f6930c4b0a4 Reviewed-on: https://chromium-review.googlesource.com/1148003 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#590839} [modify] https://crrev.com/b955903bed7c037e90beba90b19aa3bc392f959a/tools/chrome_proxy/common/chrome_proxy_benchmark.py [modify] https://crrev.com/b955903bed7c037e90beba90b19aa3bc392f959a/tools/chrome_proxy/common/chrome_proxy_metrics_unittest.py [modify] https://crrev.com/b955903bed7c037e90beba90b19aa3bc392f959a/tools/chrome_proxy/common/chrome_proxy_shared_page_state.py [modify] https://crrev.com/b955903bed7c037e90beba90b19aa3bc392f959a/tools/chrome_proxy/integration_tests/chrome_proxy_metrics_unittest.py [modify] https://crrev.com/b955903bed7c037e90beba90b19aa3bc392f959a/tools/chrome_proxy/live_tests/chrome_proxy_benchmark.py [modify] https://crrev.com/b955903bed7c037e90beba90b19aa3bc392f959a/tools/chrome_proxy/live_tests/chrome_proxy_metrics_unittest.py [modify] https://crrev.com/b955903bed7c037e90beba90b19aa3bc392f959a/tools/chrome_proxy/live_tests/pagesets/__init__.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/094b1a71b9769ea3c789e7abdec3024937b44f1c commit 094b1a71b9769ea3c789e7abdec3024937b44f1c Author: Mike Frysinger <vapier@chromium.org> Date: Wed Sep 12 23:26:21 2018 android_webview: strip trailing blank lines Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: I8808d018bb0f8aecb63994ce82324fe8a9fcabf9 Reviewed-on: https://chromium-review.googlesource.com/1222490 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#590857} [modify] https://crrev.com/094b1a71b9769ea3c789e7abdec3024937b44f1c/android_webview/tools/PRESUBMIT.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8ce26fe941a3b3211f358a34c0be5ac145aec19 commit f8ce26fe941a3b3211f358a34c0be5ac145aec19 Author: Mike Frysinger <vapier@chromium.org> Date: Mon Sep 17 13:17:06 2018 ios: strip trailing blank lines Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I780305469d6af526753ea6c52c995a541e7543a9 Reviewed-on: https://chromium-review.googlesource.com/1222635 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#591654} [modify] https://crrev.com/f8ce26fe941a3b3211f358a34c0be5ac145aec19/ios/build/tools/convert_gn_xcodeproj.py [modify] https://crrev.com/f8ce26fe941a3b3211f358a34c0be5ac145aec19/ios/chrome/browser/web/resources/PRESUBMIT.py
Hi Mike, Do you have an ETA for this work will be completed? Thanks!
Comment 1 by digit@google.com
, Jul 24