New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 866767 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in v8::internal::Factory::NewRawOneByteString

Project Member Reported by ClusterFuzz, Jul 24

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5855359907135488

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000000000c8
Crash State:
  v8::internal::Factory::NewRawOneByteString
  v8::internal::String::SlowFlatten
  v8::internal::String::Flatten
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=577291:577296

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5855359907135488

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 24

Labels: Test-Predator-Auto-Owner
Owner: delph...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/38a50805ca4ee33c7845a556e4137fbb7f03dcfb (gin: Fix use of V8_DEPRECATE_SOON methods).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 2 by ClusterFuzz, Jul 24

Components: Blink>JavaScript>GC
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
 Issue 866789  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/712beaa881590cc7e8005397421ecc6eccf1ea12

commit 712beaa881590cc7e8005397421ecc6eccf1ea12
Author: Dan Elphick <delphick@chromium.org>
Date: Tue Jul 24 17:37:24 2018

gin: fix crash on concat strings passed to ThrowError

V8TypeAsString was passing nullptr to the ConvertFromV8 function, so now
we always pass the isolate. Also adds a DCHECK to ensure that V8ToString
to ConvertFromV8 to ensure it's always passed a non-null Isolate.

Bug:  866767 
Change-Id: I715396f309a0c49e4c6bc6ade14b5f0aad8befec
Reviewed-on: https://chromium-review.googlesource.com/1148209
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577597}
[modify] https://crrev.com/712beaa881590cc7e8005397421ecc6eccf1ea12/gin/arguments.cc
[modify] https://crrev.com/712beaa881590cc7e8005397421ecc6eccf1ea12/gin/converter.h

Project Member

Comment 5 by ClusterFuzz, Jul 24

Labels: OS-Mac
Project Member

Comment 6 by ClusterFuzz, Jul 25

ClusterFuzz has detected this issue as fixed in range 577596:577597.

Detailed report: https://clusterfuzz.com/testcase?key=5855359907135488

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000000000c8
Crash State:
  v8::internal::Factory::NewRawOneByteString
  v8::internal::String::SlowFlatten
  v8::internal::String::Flatten
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=577291:577296
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=577596:577597

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5855359907135488

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jul 25

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5855359907135488 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment