New issue
Advanced search Search tips

Issue 866737 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

OOP-R: Transfer cache should match non-oop-r discardable limits on low-end

Project Member Reported by ericrk@chromium.org, Jul 24

Issue description

Currently, the OOP-R transfer cache has a 4MB cache on low-end. As the primary use of this cache turned out to be images, with only small additional colorspace and path caches, we should make this more closely match the discardable image cache's low-end size (512KB).

Suggesting 768KB to give 256KB for additional non-image data.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca3a0cec7a2bcf912c2c8764da67d032d5eb8dee

commit ca3a0cec7a2bcf912c2c8764da67d032d5eb8dee
Author: Eric Karl <ericrk@chromium.org>
Date: Tue Jul 24 17:53:05 2018

OOP-R: Lower Transfer Cache Limits for low-end Android

Currently, the OOP-R transfer cache has a 4MB cache on low-end. As the
primary use of this cache turned out to be images, with only small
additional colorspace and path caches, we should make this more closely
match the discardable image cache's low-end size (512KB).

Chosing 768KB to allow for small amounts of additional cache items.

R=khushalsagar

Bug:  866737 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2f04ce5bac3d2d94bb73bfd877169947d7aae64d
Reviewed-on: https://chromium-review.googlesource.com/1147759
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577603}
[modify] https://crrev.com/ca3a0cec7a2bcf912c2c8764da67d032d5eb8dee/gpu/command_buffer/service/service_transfer_cache.cc

Labels: Merge-Request-69
This issue will cause a memory regression on low-end Android if OOP-R ships in M69. Would like to merge to M69 as this is a trivial change.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 25

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 27

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db3b95eaae37bca9150aa20eb6e8fc53f4c09ed1

commit db3b95eaae37bca9150aa20eb6e8fc53f4c09ed1
Author: Eric Karl <ericrk@chromium.org>
Date: Fri Jul 27 18:40:42 2018

OOP-R: Lower Transfer Cache Limits for low-end Android

Currently, the OOP-R transfer cache has a 4MB cache on low-end. As the
primary use of this cache turned out to be images, with only small
additional colorspace and path caches, we should make this more closely
match the discardable image cache's low-end size (512KB).

Chosing 768KB to allow for small amounts of additional cache items.

R=khushalsagar
TBR=ericrk@chromium.org

(cherry picked from commit ca3a0cec7a2bcf912c2c8764da67d032d5eb8dee)

Bug:  866737 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2f04ce5bac3d2d94bb73bfd877169947d7aae64d
Reviewed-on: https://chromium-review.googlesource.com/1147759
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577603}
Reviewed-on: https://chromium-review.googlesource.com/1153491
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#169}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/db3b95eaae37bca9150aa20eb6e8fc53f4c09ed1/gpu/command_buffer/service/service_transfer_cache.cc

Status: Fixed (was: Assigned)

Sign in to add a comment