New issue
Advanced search Search tips

Issue 866730 link

Starred by 2 users
Status: Fixed
Owner:
mahmadi@chromium.org
Closed: Jul 24
Cc:
ftirelo@chromium.org
mahmadi@chromium.org
sczs@chromium.org
rohitrao@chromium.org
rogerm@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Various AutofillSettingsTestCases failing.

Project Member Reported by justincohen@chromium.org, Jul 24 
Disabling:
AutofillSettingsTestCase/testAutofillProfileEditing
AutofillSettingsTestCase/testAccessibilityOnAutofillProfileEditPage
AutofillSettingsTestCase/testAutofillProfileSaving
AutofillSettingsTestCase/testListViewEditMode
AutofillSettingsTestCase/testAccessibilityOnAutofillProfileViewPage

It starting failing upstream here: 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-full-configs/8325
and then more simulator device types failed here:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-full-configs/8326

But none of the relevant AutoFill tests have anything to do with this.

In fact, reverting back to e72294616387f89cb2036f962cc99f2d3a6ea05b which was green, I still fail locally.  So disabling the tests for now and kicking over to autofill.

Comment 1 by justincohen@chromium.org, Jul 24

Cc: sczs@chromium.org rohitrao@chromium.org

Comment 2 by ma...@chromium.org, Jul 24

Owner: mahmadi@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e8f9218c0f90c57df0c6ba8cbfe6d719ea79e58

commit 5e8f9218c0f90c57df0c6ba8cbfe6d719ea79e58
Author: Justin Cohen <justincohen@google.com>
Date: Tue Jul 24 00:47:32 2018

[ios] Disable failing autofill tests.

TBR: sczs@chromium.org
Bug:  866730 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibc3828d336d5f6247f2a656d747e35847f86fd70
Reviewed-on: https://chromium-review.googlesource.com/1147701
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577384}
[modify] https://crrev.com/5e8f9218c0f90c57df0c6ba8cbfe6d719ea79e58/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1523a7e02bc6c56ee243fe48257377ad03c898a

commit d1523a7e02bc6c56ee243fe48257377ad03c898a
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Jul 24 16:01:24 2018

Revert "[ios] Disable failing autofill tests."

This reverts commit 5e8f9218c0f90c57df0c6ba8cbfe6d719ea79e58.

Reason for revert:
These tests failed due to a change to the Autofill predictions server in which it started sending UNKNOWN_TYPE for unknown fields (which signals Autofill not to fill and save form data) rather than NO_SERVER_DATA ( which signals Autofill to fall back to the local heuristics). Since these tests rely on saving a profile in order to populate the settings page and that the test form wasn't known to the predictions server, they started to fail.  crbug.com/866922  is filed to eliminate that dependency.

Original change's description:
> [ios] Disable failing autofill tests.
> 
> TBR: sczs@chromium.org
> Bug:  866730 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: Ibc3828d336d5f6247f2a656d747e35847f86fd70
> Reviewed-on: https://chromium-review.googlesource.com/1147701
> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577384}

TBR=rohitrao@chromium.org,justincohen@chromium.org,kkhorimoto@chromium.org,sczs@chromium.org

Change-Id: Iba5ecab647a979cebf6d4b32894c665b356037b5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  866730 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1148502
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577563}
[modify] https://crrev.com/d1523a7e02bc6c56ee243fe48257377ad03c898a/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm

Comment 5 by gov...@chromium.org, Jul 24 

Pls apply appropriate OSs label. Thank you.

Comment 6 by sczs@chromium.org, Jul 24

Labels: OS-iOS
Status: Fixed (was: Assigned)
This seems to be fixed now, please change it back if not.
►

Sign in to add a comment