Taller tabs mean some themes have gaps below tabs |
|||||||
Issue descriptionSome themes have gaps below the background tabs because the taller tab height means the themes' tab background images don't reach to the bottom. Fix: In such cases, vertically tile the tab background image, mirrored.
,
Jul 28
,
Jul 29
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 29
Please merge your change to M69 branch 3497 by 2:00 PM PT Monday, 07/30, so we can pick it up for next week last M69 Dev release. Thank you.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a05dbee5c5200973e71a65c3b18c6703606cafa7 commit a05dbee5c5200973e71a65c3b18c6703606cafa7 Author: Peter Kasting <pkasting@chromium.org> Date: Mon Jul 30 20:36:34 2018 Mirror the inactive tab background image vertically if necessary. Refresh makes tabs taller, and some themes don't provide a background image of sufficient height. Tiling by repeating risks looking bad for themes that e.g. put a line across the top of tabs. Mirroring can look bad in a lot of cases too, but it's better than tiling or doing nothing. Most of this patch is plumbing to expose per-axis tiling modes. Bug: 866668 Change-Id: Ia6e00a15146e3eb32cda3c8362de4e83e67a8b7f Reviewed-on: https://chromium-review.googlesource.com/1147740 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578190}(cherry picked from commit b5a1628b71a1b431130833dd193dc1f74a4358aa) Reviewed-on: https://chromium-review.googlesource.com/1155607 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#238} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/a05dbee5c5200973e71a65c3b18c6703606cafa7/ash/wallpaper/wallpaper_view.cc [modify] https://crrev.com/a05dbee5c5200973e71a65c3b18c6703606cafa7/chrome/browser/themes/browser_theme_pack.cc [modify] https://crrev.com/a05dbee5c5200973e71a65c3b18c6703606cafa7/chrome/browser/ui/views/tabs/new_tab_button.cc [modify] https://crrev.com/a05dbee5c5200973e71a65c3b18c6703606cafa7/ui/gfx/canvas.cc [modify] https://crrev.com/a05dbee5c5200973e71a65c3b18c6703606cafa7/ui/gfx/canvas.h [modify] https://crrev.com/a05dbee5c5200973e71a65c3b18c6703606cafa7/ui/gfx/skia_paint_util.cc [modify] https://crrev.com/a05dbee5c5200973e71a65c3b18c6703606cafa7/ui/gfx/skia_paint_util.h
,
Jul 30
,
Aug 1
pkasting@ : Could you please provide manual repro steps for verification of fix. Thanks.!
,
Aug 1
Install the Typography theme and see if the blue background for background tabs goes all the way to the toolbar.
,
Aug 14
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh . |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jul 26