New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 866666 link

Starred by 3 users
Status: Fixed
Owner:
hirosh...@chromium.org
Closed: Dec 3
Cc:
panicker@chromium.org
█ kozyatinskiy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 861564



Sign in to add a comment

Context names of workers/worklets that appear in DevTools

Project Member Reported by hirosh...@chromium.org, Jul 23 
In current Chromium, workers/worklets are shown on DevTools like:

1. LayoutWorket: "LayoutWorklet #1 / IFrame"
  https://googlechromelabs.github.io/houdini-samples/layout-worklet/masonry/
2. PaintWorklet: "PaintWorklet #1 / IFrame"
  https://googlechromelabs.github.io/houdini-samples/paint-worklet/checkerboard/
3. AnimationWorklet: "index.html / googlechromelabs.github.io"
  https://googlechromelabs.github.io/houdini-samples/animation-worklet/parallax-scrolling/index.html
   (Note: If "index.html" is omitted, then full URL is shown)
4. AudioWorklet: "worklet.html / googlechromelabs.github.io"
  https://googlechromelabs.github.io/web-audio-samples/audio-worklet/basic/hello-audio-worklet.html
5. Workers: request URL / request origin
  http://mdn.github.io/simple-web-worker/

This issue tracks changes to these names, mainly driven by Issue 861564.
Planned immediate action items are
- Set appropriate origins for 1. and 2. (IFrame is clearly wrong),
- Set response URL for 5. when we switch worker global scope's URL to response URL in Issue 861564.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2d4f9d463a01cdd194437a3f62f68cab9eadb7f

commit f2d4f9d463a01cdd194437a3f62f68cab9eadb7f
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Jul 27 19:43:43 2018

Show origin for Paint/LayoutWorklet in DevTools context selector

Previously, an opaque origin is passed to
MainThreadDebugger::ContextCreated() for Paint/Layout worklets,
and caused the origins in the context selector shown as "IFrame".

This CL passes DocumentSecurityOrigin() instead, which is the
origin of the Document that creates the worklets, and thus
shows the correct origin.

Bug:  866666 , 861564
Change-Id: Ic038b3901ed0e301e4d2d9afdf632f7caf6add77
Reviewed-on: https://chromium-review.googlesource.com/1141290
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578754}
[modify] https://crrev.com/f2d4f9d463a01cdd194437a3f62f68cab9eadb7f/third_party/WebKit/LayoutTests/http/tests/devtools/console/paintworklet-console-selector-expected.txt
[modify] https://crrev.com/f2d4f9d463a01cdd194437a3f62f68cab9eadb7f/third_party/WebKit/LayoutTests/http/tests/devtools/console/paintworklet-console-selector.js
[modify] https://crrev.com/f2d4f9d463a01cdd194437a3f62f68cab9eadb7f/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope.cc
[modify] https://crrev.com/f2d4f9d463a01cdd194437a3f62f68cab9eadb7f/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope.cc

Comment 2 by hirosh...@chromium.org, Jul 30

Cc: panicker@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50094223b687458f7ae9089bac76196d6ca296f3

commit 50094223b687458f7ae9089bac76196d6ca296f3
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Aug 01 04:44:27 2018

Remove dependency from WorkerThreadDebugger to global scope's Url()

Previously, WorkerThreadDebugger::ContextCreated() sets
V8ContextInfo using global scope's Url().
However, After [1] Url() can be null when the global scope is
created and thus ContextCreated() can't use Url().

This CL uses |GlobalScopeCreationParams::script_url| instead.
This CL shouldn't change the behavior, because currently
global scope's Url() is equal to
|GlobalScopeCreationParams::script_url|.

[1] https://chromium-review.googlesource.com/1139074

Bug:  866666 , 861564
Change-Id: Ic19a87d77c4b01d3f850e51ce734dae11e1b4e44
Reviewed-on: https://chromium-review.googlesource.com/1139052
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579702}
[modify] https://crrev.com/50094223b687458f7ae9089bac76196d6ca296f3/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc
[modify] https://crrev.com/50094223b687458f7ae9089bac76196d6ca296f3/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.h
[modify] https://crrev.com/50094223b687458f7ae9089bac76196d6ca296f3/third_party/blink/renderer/core/inspector/worker_thread_debugger.cc
[modify] https://crrev.com/50094223b687458f7ae9089bac76196d6ca296f3/third_party/blink/renderer/core/inspector/worker_thread_debugger.h
[modify] https://crrev.com/50094223b687458f7ae9089bac76196d6ca296f3/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope.cc
[modify] https://crrev.com/50094223b687458f7ae9089bac76196d6ca296f3/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/50094223b687458f7ae9089bac76196d6ca296f3/third_party/blink/renderer/core/workers/worker_thread.cc
[modify] https://crrev.com/50094223b687458f7ae9089bac76196d6ca296f3/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope.cc

Comment 4 by pfeldman@chromium.org, Dec 3

Status: Fixed (was: Started)
Assuming this is fixed.

Comment 5 by francos6...@gmail.com, Dec 5 

francis

On Tue, Dec 4, 2018, 7:15 AM pfeld… via monorail <
monorail+v2.2946796515@chromium.org wrote:
►

Sign in to add a comment