NTB background is offset |
|||||||||||
Issue descriptionThe NTB background is horizontally offset by the contents insets. Easy fix.
,
Jul 23
,
Jul 23
,
Jul 23
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3b0effbe9f638243dae263af97794bf010170c1 commit c3b0effbe9f638243dae263af97794bf010170c1 Author: Peter Kasting <pkasting@chromium.org> Date: Tue Jul 24 15:45:42 2018 Fix NTB X coordinate for painting. Things still look wrong even with this patch, because the Y coordinate is also wrong; that's a deeper issue tracked in bug 866671 . Bug: 866665 Change-Id: I6a5f8fb159b3a70d71d1d17c904d2bd2d6d4fc6f Reviewed-on: https://chromium-review.googlesource.com/1147085 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#577558} [modify] https://crrev.com/c3b0effbe9f638243dae263af97794bf010170c1/chrome/browser/ui/views/tabs/new_tab_button.cc
,
Jul 24
,
Jul 24
,
Jul 25
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25
Pls merge your change to M69 branch 3497 latest by 3:00 PM PT today, Wednesday (07/25/18). Thank you.
,
Jul 26
Please merge your change to M69 branch 3497 by 4:00 PM PT today, so we can pick it up for next week last M69 Dev release. Thank you.
,
Jul 27
Please merge your change to M69 branch 3497 by 4:00 PM PT today, so we can pick it up for next week LAST M69 Dev release before Beta promotion. Thank you.
,
Jul 29
Please merge your change to M69 branch 3497 by 2:00 PM PT Monday, 07/30, so we can pick it up for next week last M69 Dev release. Thank you.
,
Jul 30
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61afb6d2ba249d2ed396dde694a44ae1c2a6f9d5 commit 61afb6d2ba249d2ed396dde694a44ae1c2a6f9d5 Author: Peter Kasting <pkasting@chromium.org> Date: Mon Jul 30 19:18:58 2018 Fix NTB X coordinate for painting. Things still look wrong even with this patch, because the Y coordinate is also wrong; that's a deeper issue tracked in bug 866671 . Bug: 866665 Change-Id: I6a5f8fb159b3a70d71d1d17c904d2bd2d6d4fc6f Reviewed-on: https://chromium-review.googlesource.com/1147085 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577558}(cherry picked from commit c3b0effbe9f638243dae263af97794bf010170c1) Reviewed-on: https://chromium-review.googlesource.com/1155488 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#228} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/61afb6d2ba249d2ed396dde694a44ae1c2a6f9d5/chrome/browser/ui/views/tabs/new_tab_button.cc
,
Jul 30
,
Aug 1
@Peter Kasting: Could you please provide manual reproducible steps with actual and excepted behaviour which helps us in verifying the fix from the TE end. Thanks!
,
Aug 1
Not really. This particular patch can't easily be testing in isolation from a variety of other patches.
,
Aug 14
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh . |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by pkasting@chromium.org
, Jul 23