New issue
Advanced search Search tips

Issue 866643 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Single buffer mode for NACL plug-in flickers on updates

Project Member Reported by dcasta...@chromium.org, Jul 23

Issue description

Google Keep flickers on input, this has been reported in b/111601347

The issue was caused by crrev.com/c/1097696 and we're working on a fix with crrev.com/c/1144486

This bug is to track the issue on the chromium side and to be able to mark this issue as release blocker.
 
Cc: dcasta...@chromium.org
 Issue 866948  has been merged into this issue.
Labels: -Pri-3 Pri-1
Issue 857220 has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/141a88a77294fbaaefab788ebbd7bf02c3f9fe1d

commit 141a88a77294fbaaefab788ebbd7bf02c3f9fe1d
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Mon Jul 30 19:41:23 2018

pappi: TakeFrontBuffer only once in singlebuffer mode

Single buffer mode for pepper relied on TakeFromBuffer associating
different mailboxes to the same texture.
This does not work anymore after https://crrev.com/c/1097696 and
single buffer nacl plugins now sends invalid mailboxes to the compositor.

This CL fixes the issue making sure that Graphics3D is aware of the
single buffer mode and it will associate only one mailbox, only once,
to the front buffer.

Bug:  866643 , b/111601347
Test: http://nacl-latency.firebaseapp.com runs without flickering

Change-Id: I8625fbb87bf3e9503068681bed681c88a068a123
Reviewed-on: https://chromium-review.googlesource.com/1144486
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579123}
[modify] https://crrev.com/141a88a77294fbaaefab788ebbd7bf02c3f9fe1d/content/renderer/pepper/ppb_graphics_3d_impl.cc
[modify] https://crrev.com/141a88a77294fbaaefab788ebbd7bf02c3f9fe1d/ppapi/proxy/ppb_graphics_3d_proxy.cc
[modify] https://crrev.com/141a88a77294fbaaefab788ebbd7bf02c3f9fe1d/ppapi/proxy/ppb_graphics_3d_proxy.h
[modify] https://crrev.com/141a88a77294fbaaefab788ebbd7bf02c3f9fe1d/ppapi/proxy/video_decoder_resource_unittest.cc

Labels: Merge-Request-69
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 31

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 6

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 6

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92438e6029f28368b71895b9c5538fd7e42dd4c8

commit 92438e6029f28368b71895b9c5538fd7e42dd4c8
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Mon Aug 06 22:25:23 2018

pappi: TakeFrontBuffer only once in singlebuffer mode

Single buffer mode for pepper relied on TakeFromBuffer associating
different mailboxes to the same texture.
This does not work anymore after https://crrev.com/c/1097696 and
single buffer nacl plugins now sends invalid mailboxes to the compositor.

This CL fixes the issue making sure that Graphics3D is aware of the
single buffer mode and it will associate only one mailbox, only once,
to the front buffer.

Bug:  866643 , b/111601347
Test: http://nacl-latency.firebaseapp.com runs without flickering

Change-Id: I8625fbb87bf3e9503068681bed681c88a068a123
Reviewed-on: https://chromium-review.googlesource.com/1144486
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579123}(cherry picked from commit 141a88a77294fbaaefab788ebbd7bf02c3f9fe1d)
Reviewed-on: https://chromium-review.googlesource.com/1164422
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#447}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/92438e6029f28368b71895b9c5538fd7e42dd4c8/content/renderer/pepper/ppb_graphics_3d_impl.cc
[modify] https://crrev.com/92438e6029f28368b71895b9c5538fd7e42dd4c8/ppapi/proxy/ppb_graphics_3d_proxy.cc
[modify] https://crrev.com/92438e6029f28368b71895b9c5538fd7e42dd4c8/ppapi/proxy/ppb_graphics_3d_proxy.h
[modify] https://crrev.com/92438e6029f28368b71895b9c5538fd7e42dd4c8/ppapi/proxy/video_decoder_resource_unittest.cc

Comment 9 Deleted

Status: Fixed (was: Assigned)

Sign in to add a comment