Inconsistent padding in the settings page for large font sizes |
||
Issue descriptionIn https://chromium-review.googlesource.com/c/chromium/src/+/1133300, we changed how the padding of setting-toggle-buttons is computed in order to avoid padding issues with large font sizes or longer text strings. This improved the settings UI when viewed with a large font size. However, it only applies to a certain kind of settings element. The current state is inconsistent as some elements have incorrect padding: https://imgur.com/a/vrNZ0yK. I sent out https://chromium-review.googlesource.com/c/chromium/src/+/1135554 for review which should fix most of the inconsistencies. However, there's a lot of settings pages and there's a good chance I'm breaking some other things.
,
Nov 30
Updated extensions details page to use padding instead of min-height. It doesn't actually change how it looks, but relies on padding instead of height which is more reliable.
,
Dec 1
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b84a15c4a74165175cd4ec32ff55163ad5c44e4 commit 9b84a15c4a74165175cd4ec32ff55163ad5c44e4 Author: John Lee <johntlee@chromium.org> Date: Sat Dec 01 18:32:48 2018 WebUI: Remove min-height and add padding on extensions details page to match the rest of the page Bug: 866641 Change-Id: Ie958bd21f9ea24d3ed7fd74f18e70feb238d61c8 Reviewed-on: https://chromium-review.googlesource.com/c/1357305 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#612922} [modify] https://crrev.com/9b84a15c4a74165175cd4ec32ff55163ad5c44e4/chrome/browser/resources/md_extensions/detail_view.html |
||
►
Sign in to add a comment |
||
Comment 1 by proberge@chromium.org
, Jul 23