The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1349268f945805bcc749dd5b292a77802d5f753

commit a1349268f945805bcc749dd5b292a77802d5f753
Author: Tommy Martino <tmartino@chromium.org>
Date: Tue Jul 24 00:36:07 2018

[Autofill Views] Draw separator background

Currently, we don't draw the background on the separator. This is fine
on Win and Mac, because by default we just see white anyway. But on
Linux (specifically GTK+) we draw gray by default, giving an ugly gray
splotch.

Change-Id: I6f6d61d7ade28d30a659858a9a83bf0506aa3637
Bug:  866637 
Reviewed-on: https://chromium-review.googlesource.com/1147158
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577373}
[modify] https://crrev.com/a1349268f945805bcc749dd5b292a77802d5f753/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc

Tommy, can you please add details on how to enable GTK+. I think testers will need it to validade the fix on M70.

tmartino@ : As per comment#2 could you please provide details for this issue, so that it would be really helpful for the further verification of the fix.

Thanks.!

Testing steps:

1. Start Chrome on Linux.


2. Go to chrome://settings. Under "Appearance", find and click on the big "Use GTK+" button. (It's on the right-hand side of the "Themes" row.)

If you don't see this button, but instead see only a button that says "Use Classic", you are probably already using GTK+. In this case, it should say "GTK+" right under the word "Themes."


3. Ensure that you have an Autofill profile available for filling. 

If you're not sure, go to rsolomakhin.github.io/autofill, and try to trigger Autofill by clicking the "Name" field at the top of the page. If nothing appears, click "Fill Form (Simpsons)", then "Submit". Return to this page, reload, and try again.


4. Go to http://zkoch.github.io/https-things/datalist.html. Click on the Given Name field. A dropdown should appear containing:
Bob Pickle
Sarah Pickle
Kurt Russell
Judy McFarland
<horizontal line>
<One or more of your saved Autofill names>
Manage Addresses

We want the <horizontal line> to be a thin (about 1px) gray line with some extra white space above it (about 10px). Prior to my patch, this was instead appearing as a large gray rectangle (about 10px tall) with no extra white space.

Note, the line in question will not appear unless there are Autofill names underneath it, so it's important to verify that these names appear as well.

Screenshots (Googlers only): https://drive.google.com/file/d/1rtEsswWa2U9mY_kaZ5629xxxPTmQqvnM/view?usp=sharing
https://drive.google.com/file/d/1mSSRyOFnmlaVAVyXMAaFUIE82SMWGTUy/view?usp=sharing

Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Pls merge your change to M69 branch 3497 latest by 3:00 PM PT today, Wednesday (07/25/18). Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1effdf112e085509c6df205c7b18625792f68b4

commit d1effdf112e085509c6df205c7b18625792f68b4
Author: Tommy Martino <tmartino@chromium.org>
Date: Wed Jul 25 16:52:54 2018

[Autofill Views] Draw separator background

Currently, we don't draw the background on the separator. This is fine
on Win and Mac, because by default we just see white anyway. But on
Linux (specifically GTK+) we draw gray by default, giving an ugly gray
splotch.

Change-Id: I6f6d61d7ade28d30a659858a9a83bf0506aa3637
Bug:  866637 
Reviewed-on: https://chromium-review.googlesource.com/1147158
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577373}(cherry picked from commit a1349268f945805bcc749dd5b292a77802d5f753)
Reviewed-on: https://chromium-review.googlesource.com/1150320
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#73}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/d1effdf112e085509c6df205c7b18625792f68b4/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc

Able to reproduce the issue on build without fix #69.0.3497.0 using Ubuntu 17.10.

Verified the fix on Ubuntu 17.10, as per comment#5 on latest chrome version #69.0.3497.23.
Attaching screen shot for reference.
Observed a thin gray line horizontal line with some extra white space above autofill name.
Hence, the fix is working as expected.
Adding the verified labels.

Thanks...!!

Deleted: 866637.png 198 KB

	866637.png 198 KB View Download