New issue
Advanced search Search tips

Issue 866633 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-XR



Sign in to add a comment

VR UKM getting source id from WebContents during navigation may give stale id

Project Member Reported by billorr@chromium.org, Jul 23

Issue description

UKM updates source id using a WebContentsObserver, so there is a race for whether VR or UKM gets notifications first.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdfa08e0cc0864144af88890b4bd32420ff42e77

commit fdfa08e0cc0864144af88890b4bd32420ff42e77
Author: Bill Orr <billorr@chromium.org>
Date: Wed Jul 25 18:48:10 2018

Fix an issue where VR UKM was getting possibly stale source ids

UKM updates the per-WebContents source id during WebContentsObserver callbacks.
VR fires UKM events during WebContentsObserver callbacks.  Navigation events
may get fired to VR or UKM first, so we may get stale ids.

BUG=866633

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iaf99f70b0defecd34156d64526ecd329f2315876
Reviewed-on: https://chromium-review.googlesource.com/1147504
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577994}
[modify] https://crrev.com/fdfa08e0cc0864144af88890b4bd32420ff42e77/chrome/browser/vr/metrics/session_metrics_helper.cc

Components: Internals>XR
Removing Internals>VR component and assigning to Internals>XR
Components: -Internals>VR

Sign in to add a comment