New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 866624 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

In chromium_trybot recipe, print out the names of builders that the trybot mirrors in logs

Project Member Reported by bpastene@chromium.org, Jul 23

Issue description

It's pretty unintuitive to have to look at trybots.py (https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/trybots.py) to see what builders a trybot mirrors. It'd be much more developer-friendly if it just printed in the build somewhere something along the lines of:
"
Importing build and test configs from builder(s):
android-marshmallow-arm64-rel on chromium.android
Android Release (Nexus 5X) on chromium.gpu
"

Bonus points if we can linkify the builder names.
 
Cc: gbeaty@chromium.org
+gbeaty, who recently picked up the thematically similar https://bugs.chromium.org/p/chromium/issues/detail?id=732269.
Owner: gbeaty@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0006ded39a9d3da24c8167a350ec31916b853304

commit 0006ded39a9d3da24c8167a350ec31916b853304
Author: Garrett Beaty <gbeaty@chromium.org>
Date: Fri Aug 31 17:57:57 2018

Add a step to output the builders being run in chromium_tests.

Bug:  866624 
Change-Id: I3049e16e86a9d76b80f55f63efc2052f34a2fcce
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/1153664
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder_on_buildbot.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_custom_name.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/runhooks_failure_ng.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_ng.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_script_test_with_args.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/generic_path_config.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_no_json.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/clobber_analyze.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/check_swarming_version_failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/runhooks_failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/isolated_script_test_invalid_results_handler.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_unknown_json_results.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/bot_update_failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/basic.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks__with_patch__failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/ensure_goma_fail.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/README.recipes.md
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/gtest_bad_custom_merge_script.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/isolated_script_test_bad_custom_merge_script.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/script_test_with_overridden_compile_targets.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/compile_failure_with_component_rev.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/msan.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/compile_failure_ng.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_gtest_fuchsia.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_gtest_win.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot_compile_failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile_no_source.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_gtest.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_asan_no_lsan.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/analyze_compile_mode.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_failing.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_gtest_on_builder.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/swarming_test_with_priority_expiration_and_timeout.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/one_failure_keeps_going_dynamic_tests.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_passed_json_results.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_deapply_fn.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/buildnumber_zero.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/tester.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_failed_json_results.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_serialized_gtests.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_custom_results_handler.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_json_isolated_script_test.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_script_test_failure.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_corrupt_json_results.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_unexpected_error.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/kitchen_path_config.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/tsan.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/0006ded39a9d3da24c8167a350ec31916b853304/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

Thnx for adding the "report buiders" step

Could we get it to print tester names as well? eg: mac_chromium_rel_ng should print "Mac10.13 Tests", "Mac Release (Intel)", and "Mac Retina Release (AMD)":
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/138261
Yeah no problem.

How does it sound if I modify the input for builder testers to appear like:
Running builder/tester builder-name on master master-name

And for split testers:
Running tester tester-name against builder builder-name on master master-name

#5 sgtm

Though I wonder if we have a trybot somewhere mirroring a builder-tester with the builder and tester on different masters... Can't think of one off the top of my head, but you might want to be careful w/ that
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/79d0f119a365d6b11017bdea87170bb5f64204b6

commit 79d0f119a365d6b11017bdea87170bb5f64204b6
Author: Garrett Beaty <gbeaty@chromium.org>
Date: Wed Sep 12 20:24:33 2018

Report the testers being run by a trybot.

A BotId namedtuple type was added to BotConfig to encapsulate the logic
of computing the tester mastername when a tester is part of the bot id.
Additional methods were added to BotConfig to provide read-only access
to the bot ids and to be able to get the bot type for a given bot id.

Bug:  866624 
Change-Id: I80db8e84a8f9bc47f30c9e8c2233cc934e3d46d0
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/1222386
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder_on_buildbot.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_custom_name.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/runhooks_failure_ng.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_ng.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_script_test_with_args.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/generic_path_config.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_no_json.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/clobber_analyze.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/check_swarming_version_failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/runhooks_failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/isolated_script_test_invalid_results_handler.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_unknown_json_results.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/bot_update_failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/basic.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks__with_patch__failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/ensure_goma_fail.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/gtest_bad_custom_merge_script.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/isolated_script_test_bad_custom_merge_script.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/script_test_with_overridden_compile_targets.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/compile_failure_with_component_rev.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/msan.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/compile_failure_ng.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_gtest_fuchsia.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_gtest_win.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot_compile_failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile_no_source.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_failing.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_asan_no_lsan.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/analyze_compile_mode.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_gtest.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_gtest_on_builder.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/swarming_test_with_priority_expiration_and_timeout.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/one_failure_keeps_going_dynamic_tests.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_passed_json_results.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_deapply_fn.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/buildnumber_zero.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/tester.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_failed_json_results.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_serialized_gtests.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_custom_results_handler.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_json_isolated_script_test.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_script_test_failure.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_corrupt_json_results.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_unexpected_error.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/kitchen_path_config.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/tsan.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/79d0f119a365d6b11017bdea87170bb5f64204b6/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

Status: Fixed (was: Started)

Sign in to add a comment