New issue
Advanced search Search tips

Issue 866603 link

Starred by 7 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

mojave: support accent colors

Project Member Reported by ellyjo...@chromium.org, Jul 23

Issue description

MacOS Mojave added new accent colors (System Preferences > General > Accent color). We should support these, probably by extending the logic in NativeThemeMac::ApplySystemControlTint().
 
Labels: -M-69 -Target-69 Target-70 M-70
Not happening for M69. This won't make Mojave's initial release. :(
Owner: lgrey@chromium.org
lgrey@, over to you :)
For 'blue', let's intentionally deviate and use Google Blue 600. All other accent colors can be used as-is. 
I've attached a couple cases where I think this is causing low-contrast bugs (or at least, unfortunate regressions compared to other platforms).

* The first is in the card unmasking UI from payments sync.
* The second is in the javascript page action bubble.
* The third is a working-as-expected case of the accent color being applied to form controls.

The button/checkbox get the system accent color, but at a low-saturation (like a secondary version of the color).

Compare this to the in-page use of accent colors on forms (last attachment) where the color is used at full saturation.

Is this the same bug or should I file a separate issue?
Screen Shot 2018-11-14 at 10.24.11 AM.png
84.5 KB View Download
Screen Shot 2018-11-15 at 5.00.15 PM.png
66.1 KB View Download
Screen Shot 2018-11-15 at 5.41.43 PM.png
53.0 KB View Download
We haven't landed anything for this yet, so not *caused* by accent color work, but it might be fallout for how Mojave changed system colors for dark mode/accent colors. Probably a different bug, but I can look at it.

Sign in to add a comment