Tab dragging - The dragged window in preview area |
||||
Issue descriptionChrome Version: 69.0.3497.0 OS: Chrome What steps will reproduce the problem? (1) Have a few browser windows open, enter tablet mode (2) Select a browser window that only has one tab, and tap on the tab area to drag the window. Overview should open behind the dragged window (3) Drag the window to the split drag indicator area, a preview window should show up, after releasing the tap, the window should be snapped to one side of the screen What is the expected result? The window should be snapped to one side of the screen See recorded video: https://drive.google.com/open?id=1Ps1VXj03UMceMDeZ3_puMSG-PluHAQG2 What happens instead? Sometimes the dragged window merges into the window item below it even the dragged window is in preview area See recorded video: https://drive.google.com/open?id=14fwUX8yXUoAnJrOklOGDcG2ChZFMpIVJ
,
Jul 23
Oops. Sorry. Marked the wrong label.
,
Jul 24
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/123adf989fa98d47fb3a61e9e129bca001ff171e commit 123adf989fa98d47fb3a61e9e129bca001ff171e Author: Xiaoqian Dai <xdai@chromium.org> Date: Wed Jul 25 17:09:33 2018 [Merge to M69]TabDragging: The dragged window in preview area case. When dragging a window in overview grid, if the window is dragged into the preview area, and a left or right semitransparent preview window shows up indicating the dragged window will be snapped to left or right side of the screen after releasing the mouse/touch, we should clear the selection widget on the current selected overview window item and also clear the ash::kIsDeferredTabDraggingTargetWindowKey property to prevent the dragged window to merge into the selected overview window item. See before https://drive.google.com/open?id=14fwUX8yXUoAnJrOklOGDcG2ChZFMpIVJ and after https://drive.google.com/open?id=1Ps1VXj03UMceMDeZ3_puMSG-PluHAQG2 Bug: 866592 TBR=oshima@chromium.org, sky@chromium.org Change-Id: I0cc1a009dc6efc07f3baca5519cbc26e9dbb1ec3 Reviewed-on: https://chromium-review.googlesource.com/1142483 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576927}(cherry picked from commit 58c6356f043cc7df27a55d8a09332951d3498dd4) Reviewed-on: https://chromium-review.googlesource.com/1150124 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#76} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/123adf989fa98d47fb3a61e9e129bca001ff171e/ash/wm/overview/window_grid.cc [modify] https://crrev.com/123adf989fa98d47fb3a61e9e129bca001ff171e/ash/wm/overview/window_grid.h [modify] https://crrev.com/123adf989fa98d47fb3a61e9e129bca001ff171e/ash/wm/overview/window_selector.cc [modify] https://crrev.com/123adf989fa98d47fb3a61e9e129bca001ff171e/ash/wm/overview/window_selector.h [modify] https://crrev.com/123adf989fa98d47fb3a61e9e129bca001ff171e/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc [modify] https://crrev.com/123adf989fa98d47fb3a61e9e129bca001ff171e/chrome/browser/ui/views/tabs/tab_drag_controller.cc [modify] https://crrev.com/123adf989fa98d47fb3a61e9e129bca001ff171e/chrome/browser/ui/views/tabs/tab_drag_controller.h [modify] https://crrev.com/123adf989fa98d47fb3a61e9e129bca001ff171e/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by x...@chromium.org
, Jul 23Status: Fixed (was: Assigned)