New issue
Advanced search Search tips

Issue 866564 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 850728
issue 866567



Sign in to add a comment

Get Vulkan building on CromeOS

Project Member Reported by cblume@chromium.org, Jul 23

Issue description

Vulkan currently only builds on Linux with X11.
Add ChromeOS support.
 
Blocking: 866567
This currently requires a CrOS image built with USE=vulkan and kernel 4.14 (needed for fence export).

The chrome side is easier, here's how to build with vulkan for Chrome OS eve:

cros chrome-sdk --board=eve
gn gen out_$SDK_BOARD/Release --args="$GN_ARGS enable_vulkan=true"
ninja -C out_$SDK_BOARD/Release -j1000 -k50 -l32 chrome chrome_sandbox

ozone_demo works but content will not work until viz can render without a VkSurfaceKHR.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebbca824bd43a2bf282db5a7a47fac4988788f48

commit ebbca824bd43a2bf282db5a7a47fac4988788f48
Author: Michael Spang <spang@chromium.org>
Date: Mon Jul 23 20:35:58 2018

ozone: drm: Inline vulkan_intel.h to fix build error

Including <vulkan/vulkan_intel.h> results in compilation errors when building
with the CrOS SDK, because we use vulkan.h from //third_party/vulkan.

This is a temporary issue since we're using a deprecated extension for
dmabuf import. Fix it by inlining the header.

Bug:  866564 
Test: Compile chrome with cros chrome-sdk --board=eve
Change-Id: If84ae6b503e7b0af67df72d7092d9467549eaed8
Reviewed-on: https://chromium-review.googlesource.com/1147219
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577241}
[modify] https://crrev.com/ebbca824bd43a2bf282db5a7a47fac4988788f48/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8038f34518f62304c663ca558c0860bf2a0542b

commit e8038f34518f62304c663ca558c0860bf2a0542b
Author: Michael Spang <spang@chromium.org>
Date: Mon Jul 30 18:53:22 2018

ozone: drm: Fix vulkan Chrome OS build

This broke as of b29640a793cd ("[ozone/wayland/drm] Implement gbm bo
wrapper in common.").

Bug:  866564 
Test: compile
Change-Id: Id85dbb719e39b61f11cb756bbb7212d8bfdf88b3
Reviewed-on: https://chromium-review.googlesource.com/1151457
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579104}
[modify] https://crrev.com/e8038f34518f62304c663ca558c0860bf2a0542b/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc

Sign in to add a comment