New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 866551 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task


Participants' hotlists:
media-router-fixit


Sign in to add a comment

[Media Router] Remove callback from SendRouteMessage / SendBinaryMessage API

Project Member Reported by imch...@chromium.org, Jul 23

Issue description

The callback is no longer used and can be removed from the return value in the MediaRouteProvider Mojo API. 
 
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3

commit fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3
Author: Derek Cheng <imcheng@chromium.org>
Date: Tue Sep 04 21:54:27 2018

[MediaRouter] Remove unused boolean from messaging API.

Remove the unused boolean return value from
PresentationConnection::OnMessage and
MediaRouteProvider::SendRoute[Binary]Message APIs.

No behavior change is introduced with this patch.

Bug:  866551 
Change-Id: Ie46ac5852000fa7a10fff607b3de7cc58e7ce09a
Reviewed-on: https://chromium-review.googlesource.com/1198527
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588664}
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteManager.java
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteProvider.java
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/CafMediaRouteProvider.java
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/BaseMediaRouteProvider.java
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/remoting/RemotingMediaRouteProvider.java
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/CastMessageHandlerTest.java
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/android/router/media_router_android_bridge.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/android/router/media_router_android_bridge.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/android/router/media_router_android_unittest.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/presentation/browser_presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/providers/cast/cast_media_route_provider.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/providers/cast/cast_media_route_provider.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/providers/dial/dial_media_route_provider.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/providers/dial/dial_media_route_provider.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/providers/dial/dial_media_route_provider_unittest.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy_unittest.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/test/media_router_mojo_test.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/test/media_router_mojo_test.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/test/mock_media_router.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/media/router/test/test_helper.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/browser/ui/media_router/presentation_receiver_window_controller_browsertest.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/common/media_router/mojo/media_router.mojom
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/chrome/renderer/resources/extensions/media_router_bindings.js
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/third_party/blink/public/mojom/presentation/presentation.mojom
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/third_party/blink/renderer/modules/presentation/presentation_connection.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/third_party/blink/renderer/modules/presentation/presentation_connection.h
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/third_party/blink/renderer/modules/remoteplayback/remote_playback.cc
[modify] https://crrev.com/fc6af13a9fab7c3655bb4168ed2f6bae79c6fdf3/third_party/blink/renderer/modules/remoteplayback/remote_playback.h

Owner: imch...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment