New issue
Advanced search Search tips

Issue 866540 link

Starred by 1 user
Status: Assigned
Owner:
sebmarchand@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Add a migration engine to the Local Site Characteristics DB

Project Member Reported by sebmarchand@chromium.org, Jul 23 
A migration engine should be added to the Local Site Characteristics Database to allow updating it from one version to another version. Currently any change affecting the data in the DB requires to flush it entirely.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7

commit ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Wed Jul 25 15:58:05 2018

RC: Upgrade the DB version to 1

This CL adds a version number to the Local Site Characteristics DB and
reset its content if it already exists.

Bug:  773382 , 866540,  867027 
Change-Id: I0a68ad044456ab67c39a3f1537e9ff9534920d47
Reviewed-on: https://chromium-review.googlesource.com/1147113
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577912}
[modify] https://crrev.com/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[modify] https://crrev.com/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.h
[modify] https://crrev.com/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7/chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2574bbe7aae1c9fde4043276bf94f5229a5add02

commit 2574bbe7aae1c9fde4043276bf94f5229a5add02
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Jul 27 04:00:26 2018

RC: Upgrade the DB version to 1

This CL adds a version number to the Local Site Characteristics DB and
reset its content if it already exists.

Bug:  773382 , 866540,  867027 
Change-Id: I0a68ad044456ab67c39a3f1537e9ff9534920d47
Reviewed-on: https://chromium-review.googlesource.com/1147113
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577912}(cherry picked from commit ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7)
Reviewed-on: https://chromium-review.googlesource.com/1152667
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#139}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2574bbe7aae1c9fde4043276bf94f5229a5add02/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[modify] https://crrev.com/2574bbe7aae1c9fde4043276bf94f5229a5add02/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.h
[modify] https://crrev.com/2574bbe7aae1c9fde4043276bf94f5229a5add02/chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc

Comment 3 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
►

Sign in to add a comment