New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 866539 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Can not disable "Report details to Google"

Reported by uguu....@gmail.com, Jul 23

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

Steps to reproduce the problem:
1. Go to settings -> Clean up computer
2. Disable "Report details to Google"
3. Exit all browser instances
4. Go back to settings -> Clean up computer
5. Observe that "Report details to Google" is still enabled.

What is the expected behavior?
Setting to disable software_reporter_tool.exe should stick.

What went wrong?
Setting doesn't stick.

Did this work before? No 

Chrome version: 67.0.3396.99  Channel: stable
OS Version: 10.0
Flash Version: 

Ultimately I want to disable software_reporter_tool.exe because it does excessive IO.  Chrome appears to offer the option to do it via "Report details to Google", but it's disappointly a placebo button.
 
Labels: Needs-Triage-M67
Labels: Triaged-ET TE-NeedsTriageFromHYD
The issue seems to be related to CCT. Hence, routing to inhouse team for further triaging of the issue. 

Thanks...!!
Cc: rbasuvula@chromium.org
Components: -UI UI>Settings
Cc: proberge@chromium.org ftirelo@chromium.org
Cc: -ftirelo@chromium.org csharp@chromium.org
Cc: olivierli@chromium.org
The "Report details to Google" button is unconnected to the running of the software_reporter_tool.exe.

"Report details to Google" is used to determine if anything is uploaded to Google from that cleanup.

software_reporter_tool.exe runs on a weekly scheduled to determine if a machine has unwanted software it can remove, and if so it prompts the user. It can also upload logs in certain conditions (you can see https://www.google.com/chrome/privacy/whitepaper.html#unwantedsoftware for details on when). There is no setting to disable these weekly runs.

software_reporter_tool.exe should be running with very low IO priority. Is it not running at a low priority, or are you seeing other issues?


> The "Report details to Google" button is unconnected to the running
> of the software_reporter_tool.exe.

OK, so this wasn't the option I was looking for.


> "Report details to Google" is used to determine if anything is uploaded

This sounds like the option, despite looking like a setting, is
actually a status that says whether things were uploaded after the
fact.  I am not sure how to interpret this.


> software_reporter_tool.exe should be running with very low IO
> priority. Is it not running at a low priority, or are you seeing
> other issues?

I am sensitive to unexpected disk activities, which can usually be
blamed on Windows Updates, but it's surprising to find Chrome
contributing to this problem.  Maybe it really is running at low
priority, but it's still noticeable.

For the few hours each day when I do use this windows machine, it's
very frustrating to have the various resources taken up by these
background tasks.  And it just seems wrong to me to have to leave a
computer on overnight just so that it can run various updates, in the
sense that more CPU and disk cycles are spent on updates than me doing
productive work.

If Chrome were doing these cleanups monthly instead of weekly, then I
can consolidate these maintenance hours with microsoft's patch
tuesdays.  But currently they seem to happen at most inconvenient
times.

Components: Privacy
>  There is no setting to disable these weekly runs.

Is this intentional? I can see how several users might not like periodic tasks run on their computer, without having the option to turn them off.
re #5
Sorry, I meant that "Report details to Google" is used to determine if anything should be uploaded. It is a setting that affect the cleanup run that happens after starting the cleanup.
The full details for what gets upload and by for all stuff related to the Chrome cleanup tool can be found at https://www.google.com/chrome/privacy/whitepaper.html#unwantedsoftware. 

re #6
It is by design that there is no user setting to disable the running of the reporter.
Owner: csharp@chromium.org
Status: Assigned (was: Unconfirmed)
csharp@, I'm wondering if we should just spell out next to the setting that it only applies for the following scan.

This is not the first time I'm hearing this complaint. For an organic usage of the cleanup tool it doesn't matter, but apparently there are users who go disable all the settings, then check whether their choice stuck, and are surprised.
Issue 877076 has been merged into this issue.
Labels: Hotlist-ConOps
Cc: srahim@chromium.org
Owner: proberge@chromium.org
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7715890e816a4aab493090c28d6acf5dccc6e7b

commit c7715890e816a4aab493090c28d6acf5dccc6e7b
Author: proberge <proberge@chromium.org>
Date: Mon Dec 17 15:57:17 2018

Chrome Cleanup Tool: update UI and behavior of the logs reporting option

The "Report details to Google" option is, at the moment, a settings
toggle which does not map to a real settings. This confuses users in the
following ways:
1. The setting doesn't "stick" in between browser restarts. Users are
expecting their change to the setting to apply to future browser sessions.
2. The current string could be improved to prevent users from thinking
that disabling "Report details to Google" prevents the Software Reporter
Tool from running.

This change updates the WebUI (using a checkbox instead of a settings toggle),
updates the string and makes the toggle into a real setting.

Most of the code changes are deletion since making reporting into a real
setting allows us to re-use existing settings infrastructure.

Bug:  866539 
Change-Id: I01df0ad73c377a4e3fa866694da1fbdd42ba15f3
Reviewed-on: https://chromium-review.googlesource.com/c/1373888
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617128}
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/app/generated_resources.grd
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/app/settings_strings.grdp
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_proxy.js
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/resources/settings/reset_page/reset_page.html
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.h
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/ui/webui/settings/chrome_cleanup_handler.h
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/chrome_cleaner/components/recovery_component.cc
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/chrome_cleaner/logging/cleaner_logging_service.cc
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/chrome_cleaner/logging/reporter_logging_service.cc
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/chrome/test/data/webui/settings/chrome_cleanup_page_test.js
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/components/component_updater/pref_names.cc
[modify] https://crrev.com/c7715890e816a4aab493090c28d6acf5dccc6e7b/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d89b42bc351b8dbb172a22c431c23bf8631eb17a

commit d89b42bc351b8dbb172a22c431c23bf8631eb17a
Author: proberge <proberge@chromium.org>
Date: Tue Dec 18 18:06:41 2018

Chrome Cleanup: make the reporting preference a protected profile pref

In https://chromium-review.googlesource.com/c/chromium/src/+/1373888 we
made the "software_reporter.reporting" pref into a real preference.
We consider that this preference should be protected through Secure
Preferences. However, the Local State file does not have a Secure Pref
equivalent. This change moves the software_reporter.reporting pref out
of Local State, instead adding it to the user's preferences.

Migration of the pref is not needed assuming this CL lands shortly
after https://chromium-review.googlesource.com/c/chromium/src/+/1373888,
as the Local State pref was not user-modifiable prior to that change;
the pref was used solely to allow enterprise policies to disable the
reporting of the Chrome Cleanup Tool.

Bug:  866539 
Change-Id: Icbf83b7647b5c735f3f09962327f2ffdaa441e40
Reviewed-on: https://chromium-review.googlesource.com/c/1379029
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617560}
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/browser/component_updater/sw_reporter_installer_win.cc
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.h
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_controller_win.h
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.cc
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.h
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/d89b42bc351b8dbb172a22c431c23bf8631eb17a/components/component_updater/pref_names.h

Status: Fixed (was: Assigned)
The two changes I landed makes the setting "sticky": when it's disabled by the user it stays disabled between browser session or computer re-starts.

The changes also make the string a bit clearer to avoid confusion regarding disabling logging of software_reporter_tool.exe versus disabling logging of the Chrome Cleanup Tool. 

These changes will roll out to Stable users sometime in March as part of the M73 Chrome release. If you have some spare time and have Chrome Canary installed, you should be able to see the changes in tomorrow's build. 

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=915860 to ask the testing team to re-run the test plan of the Chrome Cleanup Tool feature. 

Sign in to add a comment