New issue
Advanced search Search tips

Issue 866532 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 842365



Sign in to add a comment

Fold NativeCursorManagerAshClassic into NativeCursorManagerAsh

Project Member Reported by sky@chromium.org, Jul 23

Issue description

This was created early on in mash. We no longer need multiple implementations, so NativeCursorManagerAshClassic can be folded directly into NativeCursorManagerAsh.
 
Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79e1ed6962df30006a75e827e610e91acb4b163f

commit 79e1ed6962df30006a75e827e610e91acb4b163f
Author: James Cook <jamescook@chromium.org>
Date: Fri Sep 07 15:40:42 2018

chromeos: Collapse NativeCursorManagerAsh with its only subclass

NativeCursorManagerAshClassic is the only subclass.

I'm going to rename the file in a follow-up CL to help git rename
tracking preserve the blame history.

Bug:  866532 
Change-Id: Icb4a0ee7211a4256d6655797393d22bb43169e77
Reviewed-on: https://chromium-review.googlesource.com/1212143
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589526}
[modify] https://crrev.com/79e1ed6962df30006a75e827e610e91acb4b163f/ash/BUILD.gn
[modify] https://crrev.com/79e1ed6962df30006a75e827e610e91acb4b163f/ash/shell.cc
[modify] https://crrev.com/79e1ed6962df30006a75e827e610e91acb4b163f/ash/wm/cursor_manager_test_api.cc
[delete] https://crrev.com/91189edf0cec25ad45819e41320e2c1e7d16897b/ash/wm/native_cursor_manager_ash.h
[modify] https://crrev.com/79e1ed6962df30006a75e827e610e91acb4b163f/ash/wm/native_cursor_manager_ash_classic.cc
[modify] https://crrev.com/79e1ed6962df30006a75e827e610e91acb4b163f/ash/wm/native_cursor_manager_ash_classic.h
[modify] https://crrev.com/79e1ed6962df30006a75e827e610e91acb4b163f/ash/wm/native_cursor_manager_ash_interactive_uitest.cc
[modify] https://crrev.com/79e1ed6962df30006a75e827e610e91acb4b163f/ash/wm/native_cursor_manager_ash_unittest.cc

Labels: Proj-Mash-WS2
Status: Fixed (was: Started)

Sign in to add a comment