New issue
Advanced search Search tips

Issue 866529 link

Starred by 1 user
Status: Fixed
Owner:
msw@chromium.org
Closed: Sep 24
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 842365



Sign in to add a comment

Remove Add/RemoveLimitedPreTargetHandlerForWindow from wm_util

Project Member Reported by sky@chromium.org, Jul 23 
These were added early on for mash and are no longer necessary. Instead use Add/RemovePreTargetHandler directly.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56f2089ba668d4a80bd5f9d3159805be2b41de58

commit 56f2089ba668d4a80bd5f9d3159805be2b41de58
Author: Mike Wasserman <msw@chromium.org>
Date: Mon Sep 24 19:27:14 2018

ash: Remove *LimitedPreTargetHandlerForWindow helper functions

These were added for deprecated Mash architecture plans.
Inline calls to [Add/Remove]PreTargetHandler instead.

Bug:  866529 
Test: No shelf tooltip nor double-click-to-resize-window changes.
Change-Id: Ic4d376652e1e128c979cfdb6f5f219a2ed76f6ad
Reviewed-on: https://chromium-review.googlesource.com/1240212
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593628}
[modify] https://crrev.com/56f2089ba668d4a80bd5f9d3159805be2b41de58/ash/shelf/shelf_tooltip_manager.cc
[modify] https://crrev.com/56f2089ba668d4a80bd5f9d3159805be2b41de58/ash/wm/window_util.cc
[modify] https://crrev.com/56f2089ba668d4a80bd5f9d3159805be2b41de58/ash/wm/window_util.h
[modify] https://crrev.com/56f2089ba668d4a80bd5f9d3159805be2b41de58/ash/wm/workspace/workspace_event_handler.cc

Comment 2 by msw@chromium.org, Sep 24

Owner: msw@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment