New issue
Advanced search Search tips

Issue 866528 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 842365



Sign in to add a comment

Fold WorkspaceEventHandlerClassic into WorkspaceEventHandler

Project Member Reported by sky@chromium.org, Jul 23

Issue description

This separate was done early on for mash and is no longer necessary.
 
Labels: Proj-Mash-WS2
Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3095a12ea5b0bf6d8329dc86729263824c820887

commit 3095a12ea5b0bf6d8329dc86729263824c820887
Author: James Cook <jamescook@chromium.org>
Date: Thu Sep 13 22:25:22 2018

chromeos: Eliminate WorkspaceEventHandlerClassic

It was the only subclass of WorkspaceEventHandler, so fold it into the
superclass.

This is left over from pre-WS2 mustash, when we had a separate ash
config for mash.

Bug: 842365,  866528 
Test: ash_unittests, double-click window borders to resize windows

Change-Id: I5de319afb6e8e00b51130a9099fc7c3e9ef70cfc
Reviewed-on: https://chromium-review.googlesource.com/1225596
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591185}
[modify] https://crrev.com/3095a12ea5b0bf6d8329dc86729263824c820887/ash/BUILD.gn
[modify] https://crrev.com/3095a12ea5b0bf6d8329dc86729263824c820887/ash/wm/workspace/workspace_event_handler.cc
[modify] https://crrev.com/3095a12ea5b0bf6d8329dc86729263824c820887/ash/wm/workspace/workspace_event_handler.h
[delete] https://crrev.com/eefccbdc53b8841ba0a5791b5305a0f38759f2e9/ash/wm/workspace/workspace_event_handler_classic.cc
[delete] https://crrev.com/eefccbdc53b8841ba0a5791b5305a0f38759f2e9/ash/wm/workspace/workspace_event_handler_classic.h
[modify] https://crrev.com/3095a12ea5b0bf6d8329dc86729263824c820887/ash/wm/workspace_controller.cc

Status: Fixed (was: Started)

Sign in to add a comment