New issue
Advanced search Search tips

Issue 866526 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 842365



Sign in to add a comment

Remove AcceleratorManagerDelegate

Project Member Reported by sky@chromium.org, Jul 23

Issue description

It was added at a time when we needed. It should no longer be necessary.
 
Labels: Proj-Mash-WS2
Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dafb54f4289842a087e7cf14f1a673e74f930ea1

commit dafb54f4289842a087e7cf14f1a673e74f930ea1
Author: James Cook <jamescook@chromium.org>
Date: Fri Sep 14 16:36:15 2018

Remove ui::AcceleratorManagerDelegate

It was added in the early days of mustash to support the mus window
server. Now that we have WS2 / window service as a part of ash it isn't
needed anymore. It was only being used in tests.

Bug: 842365,  866526 
Test: ui_base_unittests, ash_unittests, manually try accelerators
Change-Id: Ib156f42103ef21c6cdaf95183bf828d0959ad84e
Reviewed-on: https://chromium-review.googlesource.com/1225594
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591370}
[modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ash/accelerators/accelerator_controller.h
[modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ash/shell.cc
[modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ui/base/BUILD.gn
[modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ui/base/accelerators/accelerator_manager.cc
[modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ui/base/accelerators/accelerator_manager.h
[delete] https://crrev.com/f47bbab27c0de5810f7db4d75c886ff0620d3fe5/ui/base/accelerators/accelerator_manager_delegate.h
[modify] https://crrev.com/dafb54f4289842a087e7cf14f1a673e74f930ea1/ui/base/accelerators/accelerator_manager_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment