New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: ----

Blocking:
issue 838380



Sign in to add a comment
link

Issue 866522: Disable AV1 support in M69 beta

Reported by johannko...@google.com, Jul 23 2018 Project Member

Issue description

Feature description:
AV1 is a new video format. However, the bitstream has not yet been finalized and is not ready to move up to the Beta branch.

This bug is to acquire approval to cherry-pick a revert of
https://chromium-review.googlesource.com/c/chromium/src/+/806875

Previous requests:
M65: https://bugs.chromium.org/p/chromium/issues/detail?id=804400
M66: https://bugs.chromium.org/p/chromium/issues/detail?id=818514
M67: https://bugs.chromium.org/p/chromium/issues/detail?id=832895
M68: https://bugs.chromium.org/p/chromium/issues/detail?id=847642

Eng owner: johannkoenig@google.com
Product owner: jaikk@google.com
 

Comment 1 by johannko...@google.com, Jul 23 2018

Jai, if this is needed for M69 please add "Merge-Request-69" label.

Comment 2 by johannko...@google.com, Jul 23 2018

Cc: jzern@chromium.org tomfinegan@chromium.org
If this is necessary, here is a pre-made revert:
https://chromium-review.googlesource.com/c/chromium/src/+/1146982

It should not be merged until merge approval is granted on this bug.

Comment 3 by marcomso...@gmail.com, Jul 26 2018

┬┐AV1-spec v1.0.0 is a draf or are final?

https://aomediacodec.github.io/av1-spec/av1-spec.pdf
Last modified: 2018-06-25 12:23 PT

This version 1.0.0 of the AV1 Bitstream Specification corresponds to the Git tag v1.0.0 in the AOMediaCodec/av1-spec project. Its content has been validated as consistent with the reference decoder provided by libaom v1.0.0.

Comment 4 by johannko...@google.com, Jul 26 2018

Status: WontFix (was: Assigned)
Apologies. I had copied the text from the previous M68 bug, before the spec was finalized. I thought I had updated the text in the description, but it appears it didn't catch.

We plan to keep AV1 enabled in M69 at this point.

Comment 5 by johannko...@google.com, Aug 22

Blocking: 838380
Labels: Merge-Request-69
Status: Started (was: WontFix)
Re-opening to disable AV1 in M69.

Comment 6 by sheriffbot@chromium.org, Aug 22

Project Member
Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by gov...@chromium.org, Aug 22

Labels: -Merge-Review-69 Merge-Approved-69
Approving merge for https://chromium-review.googlesource.com/c/chromium/src/+/1146982 to M69 branch 3497 based on internal email thread. Pls merge now. Thank you.

Comment 8 by bugdroid1@chromium.org, Aug 22

Project Member
Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3416497c874e5f121ade527e6796192818654436

commit 3416497c874e5f121ade527e6796192818654436
Author: Johann <johannkoenig@google.com>
Date: Wed Aug 22 21:51:04 2018

Revert "enable libaom"

This reverts commit 80428a9587801289b331674365fc09523319288c.

AV1 is not ready. Disable it on the M69 branch.

BUG=838380, 866522 

Change-Id: I5fcad78ded0f9e03a44b7def5fee5becd6a4cbf9
Reviewed-on: https://chromium-review.googlesource.com/1146982
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/branch-heads/3497@{#780}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/3416497c874e5f121ade527e6796192818654436/DEPS

Comment 9 by johannko...@google.com, Aug 22

Status: Fixed (was: Started)

Comment 11 by johannko...@google.com, Sep 10

Status: Assigned (was: Fixed)
Jai, looks like there are some references which should be cleaned up.

Comment 12 by jaikk@chromium.org, Sep 10

Status: Fixed (was: Assigned)
Those have since been updated to M70 launch, closing unless there are any more outstanding M69 references

Sign in to add a comment