Issue metadata
Sign in to add a comment
|
Dictation + ChromeVox: CVox doesn't wait until dictation is finished to read, stutters during dictation |
||||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3494.0 (Official Build) dev (64-bit) CrOS Firmware Version: Google_Eve.9584.160.0 Steps to repro: # Attach headphones to Chromebook (otherwise subject to bug 866519 ) # Enable ChromeVox with ctrl + alt + z # Enable Dictation via Settings > Manage Accessibility Features # Open the browser with focus in the Omnibox (or any text field) # Listen as ChromeVox reads content about focus # Press ctrl to stop it from speaking before dictating # Press ctrl + d to start dictating. Expected: CVox waits until speaking is done to start reading it back to the user Actual: CVox starts reading the first word you dictated, then interrupts itself to speak the second word, and so on. This leads to a stuttering effect. It then repeats everything dictated after it is done. Please see this video for audio of what's happening: https://drive.google.com/file/d/1ks4zYz7hDKseKzzF75W_FEK_KvKJ61F_/view
,
Jul 23
,
Jul 27
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d76633d9a9362ec8fcb772141c5fb8ce07103f52 commit d76633d9a9362ec8fcb772141c5fb8ce07103f52 Author: Zach Helfinstein <zhelfins@chromium.org> Date: Tue Jul 31 18:00:16 2018 Stop dictation text update when ChromeVox enabled Also add tests for Dictation Bug: 866521 Change-Id: I551b97cdc9d7f0374985438b94c538c45daddf52 Reviewed-on: https://chromium-review.googlesource.com/1152514 Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#579478} [modify] https://crrev.com/d76633d9a9362ec8fcb772141c5fb8ce07103f52/chrome/browser/chromeos/accessibility/accessibility_manager.h [modify] https://crrev.com/d76633d9a9362ec8fcb772141c5fb8ce07103f52/chrome/browser/chromeos/accessibility/dictation_chromeos.cc [modify] https://crrev.com/d76633d9a9362ec8fcb772141c5fb8ce07103f52/chrome/browser/chromeos/accessibility/dictation_chromeos.h [add] https://crrev.com/d76633d9a9362ec8fcb772141c5fb8ce07103f52/chrome/browser/chromeos/accessibility/dictation_chromeos_browsertest.cc [modify] https://crrev.com/d76633d9a9362ec8fcb772141c5fb8ce07103f52/chrome/test/BUILD.gn
,
Aug 1
,
Aug 1
Set to land in 70.0.3509.0. Will verify after Canary channel reaches that.
,
Aug 10
Chrome Version: 70.0.3511.0 (Official Build) canary (64-bit) CrOS Firmware Version: Google_Eve.9584.160.0 Verified. Followed these steps: # Attach headphones to Chromebook (otherwise subject to bug 866519 ) # Enable ChromeVox with ctrl + alt + z # Enable Dictation via Settings > Manage Accessibility Features # Open the browser with focus in the Omnibox (or any text field) # Listen as ChromeVox reads content about focus # Press ctrl to stop it from speaking before dictating # Press ctrl + d to start dictating. ChromeVox did not start repeating back what was entered until all of the text was entered. Works as expected.
,
Aug 10
,
Aug 13
,
Aug 13
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 15
Merge approved, M69
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/440d9e8543c4b13e08e0ab489a48c75556cb7ec3 commit 440d9e8543c4b13e08e0ab489a48c75556cb7ec3 Author: Zach Helfinstein <zhelfins@chromium.org> Date: Wed Aug 15 23:03:09 2018 Merge to M69: Stop dictation text update when ChromeVox enabled Bug: 866521 Change-Id: I551b97cdc9d7f0374985438b94c538c45daddf52 Reviewed-on: https://chromium-review.googlesource.com/1152514 Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579478}(cherry picked from commit d76633d9a9362ec8fcb772141c5fb8ce07103f52) Reviewed-on: https://chromium-review.googlesource.com/1176501 Cr-Commit-Position: refs/branch-heads/3497@{#663} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/440d9e8543c4b13e08e0ab489a48c75556cb7ec3/chrome/browser/chromeos/accessibility/accessibility_manager.h [modify] https://crrev.com/440d9e8543c4b13e08e0ab489a48c75556cb7ec3/chrome/browser/chromeos/accessibility/dictation_chromeos.cc [modify] https://crrev.com/440d9e8543c4b13e08e0ab489a48c75556cb7ec3/chrome/browser/chromeos/accessibility/dictation_chromeos.h [add] https://crrev.com/440d9e8543c4b13e08e0ab489a48c75556cb7ec3/chrome/browser/chromeos/accessibility/dictation_chromeos_browsertest.cc [modify] https://crrev.com/440d9e8543c4b13e08e0ab489a48c75556cb7ec3/chrome/test/BUILD.gn |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by leberly@chromium.org
, Jul 23