[css-scroll-snap] Touch scrolling causes subtle oscillation |
||||||
Issue descriptionRepro steps: 1. Load https://snap.glitch.me/carousel.html 2. Enable "Touch input" using devtools > sensors 3. Scroll using touch What happens? When scroll ends at the snap point, there is a subtle oscillating behavior. This should not happen. I am not sure if touch emulation has anything to do with it but in any case we should find out what is happening and if it affect regular touch scrolling then try to get fix this for M69. See attached video. Version tested: Chromium 69.0.3494.0 (Developer Build) (64-bit) Revision d059788bbef3a57d5d4832945f5d25121cb05867-refs/heads/master@{#575248} OS Linux
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e86044fc6f467d5384d523c244235f2f4750ca88 commit e86044fc6f467d5384d523c244235f2f4750ca88 Author: Sandra Sun <sunyunjia@chromium.org> Date: Fri Aug 17 17:53:37 2018 End the snap fling within 1 pixel of destination. The scroll offsets returned from blink are only integers. However, if the target snap offset is fractional, it will never reach the destination and will oscillate between the two closest integers until it reaches the maximum time duration. In this patch, we end the snap fling if we've reached the 1-pixel range of the destination. Bug: 866517 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I185fd4267c626e1f4e561e9bd92a962c8f289d38 Reviewed-on: https://chromium-review.googlesource.com/1159088 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#584119} [modify] https://crrev.com/e86044fc6f467d5384d523c244235f2f4750ca88/cc/input/snap_fling_curve.cc [modify] https://crrev.com/e86044fc6f467d5384d523c244235f2f4750ca88/cc/input/snap_fling_curve.h [modify] https://crrev.com/e86044fc6f467d5384d523c244235f2f4750ca88/cc/input/snap_fling_curve_unittest.cc
,
Aug 20
Snap points will be shipped in M69 but this bug seriously affects its functionality, especially on Android. Now the bug is fixed, please approve to merge it in M69. Thanks!
,
Aug 20
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 20
sunyunjia@ I assume this also affects Windows and Chrome platforms too or am I missing something?
,
Aug 20
Adding them as well.
,
Aug 20
How is the change listed at #2 looking in canary? Is it safe to merge now?
,
Aug 20
It is working well in canary now and should be safe to merge.
,
Aug 20
Approving merge to M69 branch 3497 based on comment #3 and #8. Please merge ASAP,Thank you.
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69ccb2fba9844d837fbc4e325b5630114b68a700 commit 69ccb2fba9844d837fbc4e325b5630114b68a700 Author: Sandra Sun <sunyunjia@chromium.org> Date: Mon Aug 20 15:38:35 2018 End the snap fling within 1 pixel of destination. The scroll offsets returned from blink are only integers. However, if the target snap offset is fractional, it will never reach the destination and will oscillate between the two closest integers until it reaches the maximum time duration. In this patch, we end the snap fling if we've reached the 1-pixel range of the destination. Bug: 866517 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I185fd4267c626e1f4e561e9bd92a962c8f289d38 Reviewed-on: https://chromium-review.googlesource.com/1159088 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#584119}(cherry picked from commit e86044fc6f467d5384d523c244235f2f4750ca88) Reviewed-on: https://chromium-review.googlesource.com/1181282 Reviewed-by: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#709} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/69ccb2fba9844d837fbc4e325b5630114b68a700/cc/input/snap_fling_curve.cc [modify] https://crrev.com/69ccb2fba9844d837fbc4e325b5630114b68a700/cc/input/snap_fling_curve.h [modify] https://crrev.com/69ccb2fba9844d837fbc4e325b5630114b68a700/cc/input/snap_fling_curve_unittest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sunyunjia@chromium.org
, Jul 24