Perf dashboard alert grouping usually doesn't show all alerts in group |
|||
Issue descriptionI think this change happened when we switched from server->client alerts, or later. I'm seeing it both on the old perf dashboard and v2spa. Here is an example alert group: https://chromeperf.appspot.com/group_report?sid=0bf984865717038e9c8bc9b50ba878341f20e6f58727cd2688a39b2b248e90eb The old perf dashboard shows that there are two alerts in the group, but when you click "graph", you see that there are actually 6 alerts in the group. The other 4 have already been triaged. Most of the time when this happens, we want all the untriaged alerts to go with the bug that's already been triaged. But both the old dashboard and v2spa make this really hard: by default they only show the two alerts and don't show the rest of the group at all. Here are screenshots of this in the old dashboard and v2spa. I'm a bit worried that it's so hard to see there are bugs with lots of similar alerts already filed in v2spa.
,
Jul 24
Thanks! I've added this to the list of core features in go/chromeperf-v2-status. Let me see if I understand the problem and then I'll try to have a mock to discuss at the services weekly tomorrow? The V1/alerts page and V2 alerts-section only show untriaged alerts by default. However, there might be relevant triaged alerts that sheriffs need to see in order to triage. For example, bots upload data at different times, so an alert may be created for one bot, then a sheriff may triage it, then another alert for the same timeseries at about the same revision range may be created for another bot. A sheriff should triage the new alert to the same bug as the first alert. In order to do that, they need to be able to see the first alert and its bug. They could show all untriaged alerts, but that's a huge firehose. Alternatively, the UI could hide untriaged alerts from sheriffs until all of their test suite's bots have caught up to them. However, this would increase the latency between when a regression is committed and when pinpoint can find it. The V1 UI solves this problem by displaying overlapping triaged alerts in the /group_report page, but V2 doesn't solve this problem yet. One possible solution I've been considering is adding a button like "open overlapping alerts" that would open a new alerts section containing both triaged and untriaged alerts that overlap the combined revision range of selected alerts. This would effectively produce the same alerts table as the V1/group_report page currently provides. However, multiple alerts sections might require users to scroll up and down a lot. While significantly better than opening multiple tabs, a more localized UI might be even better. For example, there might be room for another small column of buttons in the alerts table. These buttons would contain the number of triaged alerts that would be grouped with a given alert or group. When clicked, they display/hide table rows containing the triaged alerts directly underneath the untriaged alert/group, possibly sub-grouped by bug. Let me know if you have any thoughts, otherwise I'll follow up with you when I have a prototype. Thanks!
,
Jul 25
Thanks for re-summarizing. You've understood the problem correctly. Let's definitely chat in the services meeting tomorrow!
,
Aug 28
Please take a look at the prototype: https://v2spa-dot-chromeperf.appspot.com/#sheriff=Chromium_Perf_Sheriff We can discuss this in the services weekly tomorrow.
,
Aug 28
I'm OOO so comments will be short, but: * Overall looks great * I think the best way to get feedback on it would be to sit with a perf sheriff, but it looks like there aren't any in MTV soon. Maybe ask Mustaq if he'd like to VC and try it out? * One thing I was surprised by is that even though I was looking for it, my eyes went right past the bug id column. I wonder if there's some visual treatment we could give for it that shows it's triaged already? Either the specific column for bug id, or just the whole row?
,
Jan 16
(6 days ago)
Is this a blocker for v2spa, https://bugs.chromium.org/p/chromium/issues/detail?id=918193 ?
,
Jan 16
(6 days ago)
I don't think so. I think this code was all server-side, and when I last touched it, was completely independent of v2 spa.
,
Jan 17
(6 days ago)
I added a "Triaged" column to the alerts table containing an expand-button that displays triaged alerts alongside untriaged alerts. I received positive feedback about it, so I'll close this bug. When v2spa is closer to launching, I'll see if it needs more polish, and file separate bugs as necessary. |
|||
►
Sign in to add a comment |
|||
Comment 1 by sullivan@chromium.org
, Jul 24